Packer: Amazon: Enable ENA registration support for new instance types

[phobos182]

AWS has new instance types which support a new Elastic Network Adapter (ENA), much like SR-IOV. Packer should allow us to set support for ENA while registering a new image, much like SR-IOV inside of the templates.

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/enhanced-networking-ena.html

[kwilczynski]

@phobos182 since I need this too, I will get this done, I hope.

Since the attribute name "enchaned_networking" is just a boolean at the moment, since back when it was added only the SR-IOV (Intel 82599 VF) was available, we would need to introduce another attribute called "enchanced_networking_type" which would take either "sriov" (maybe "simple" would be better?) or "ena" and set it accordingly.

Internally, the API takes an attribute with an attribute value, and for SR-IOV it is a string that spells "simple", whereas for ENA the attribute value is a boolean type, so just true/false to enable/disable. That is why I am thinking about introducing new attribute for setting up the type.

Any thoughts before I get a stab at this, @phobos182 and @cbednarski ?

[kwilczynski]

To add.

The reason why I was thinking about adding other option, as changing the existing one to accept a string instead of a boolean would be a breaking change. For people will older templates this might be an issue. Although, if it's fine, then we could just have e.g.

enhanced_networking": "sirov"

And that would be it.

[kwilczynski]

Support for Enhanced Networking will be coming to Terraform in the future, as per: https://github.com/hashicorp/terraform/issues/7815, hopefully.

[mwhooker]

This sounds reasonable, but isn't something we're targeting for 1.0, so I'm going to close this. There is a WIP PR out for this (#4312), and as soon as it's ready to go, we'll merge it. There are some specific things in the PR that need doing, so help wanted there. Please see the mailing list for more details on 1.0.

edit: it's #4312

[polipavs]

Glad to hear your comments and I am new to this Concept please suggest me if you need more information, we are using ena version 1.2.0 and ixgbevf 4.1.0-k-rh7.5 and i would like to update the ENA driver to the latest version https://github.com/amzn/amzn-drivers/releases, May i know how should i do that in packer, for now i have seen this "ena_support": "true" in my packer template

[hashibot[bot]]

I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.