P5.js: Broken link to custom cursor on /reference/#/p5/cursor

[jgordon510]

Most appropriate sub-area of p5.js?

• [ ] Color
• [ ] Core/Environment/Rendering
• [ ] Data
• [ ] Dom
• [ ] Events
• [ ] Image
• [ ] IO
• [ ] Math
• [ ] Typography
• [ ] Utilities
• [ ] WebGL
• [x] Other - Reference Docs

Details about the bug:

The website example at: https://p5js.org/reference/#/p5/cursor isn't working correctly. In the bottom right-corner of the example, it should produce a custom cursor hosted at: https://s3.amazonaws.com/mupublicdata/cursor.cur but the url is dead, which breaks that portion of the example.

Here's the url in context:
function draw() { line(width / 2, 0, width / 2, height); line(0, height / 2, width, height / 2); if (mouseX < 50 && mouseY < 50) { cursor(CROSS); } else if (mouseX > 50 && mouseY < 50) { cursor('progress'); } else if (mouseX > 50 && mouseY > 50) { cursor('https://s3.amazonaws.com/mupublicdata/cursor.cur'); } else { cursor('grab');

[welcome[bot]]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[Rizz0S]

I'll take this if I'm allowed. Seems like a pretty easy fix. Is there a specific cursor it needs to be replaced with?

[montoyamoraga]

hi @jgordon510 thank you for pointing this out!
thank you @Rizz0S for offering to help,
it does look an easy fix, and i suggest replacing the call of the website
with one of the CSS ones mentioned on the reference
ARROW, CROSS, HAND, MOVE, TEXT and WAIT
i am assigning you this issue, thanks!

[jgordon510]

I'm not sure replacing with one of the standard CSS icons really achieves
the purpose of that section of the code. It's supposed to show how to load
a custom image.

On Mon, May 4, 2020 at 2:48 PM aarón montoya-moraga <
[email protected]> wrote:

hi @jgordon510 https://github.com/jgordon510 thank you for pointing
this out!
thank you @Rizz0S https://github.com/Rizz0S for offering to help,
it does look an easy fix, and i suggest replacing the call of the website
with one of the CSS ones mentioned on the reference
ARROW, CROSS, HAND, MOVE, TEXT and WAIT
i am assigning you this issue, thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/processing/p5.js/issues/4513#issuecomment-623725902,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2DA62U2GCHGGOM6X3CEQTRP4Z3FANCNFSM4MY5ITJA
.

[montoyamoraga]

@jgordon510 that's true, :)
instead of depending of assets hosted somewhere else, i propose we use
the avatar of github.com/processing, and we can pick either 16x16 or 32x32
https://avatars0.githubusercontent.com/u/1617169?s=16
https://avatars0.githubusercontent.com/u/1617169?s=32

[jgordon510]

That sounds like a great solution.

On Mon, May 4, 2020 at 6:14 PM aarón montoya-moraga <
[email protected]> wrote:

@jgordon510 https://github.com/jgordon510 that's true, :)
instead of depending of assets hosted somewhere else, i propose we use
the avatar of github.com/processing, and we can pick either 16x16 or 32x32
https://avatars0.githubusercontent.com/u/1617169?s=16
https://avatars0.githubusercontent.com/u/1617169?s=32

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/processing/p5.js/issues/4513#issuecomment-623788834,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB2DA67EL23AAYTNDSHOUKTRP5R57ANCNFSM4MY5ITJA
.

[Rizz0S]

Thanks y'all! Made the appropriate change - do I need to do anything in the p5.js-website repo as well, or will this change be sufficient?

[montoyamoraga]

@Rizz0S thank you! your PR is great and enough, the build of the website is automatic,
also i added you to the contributors of p5.js :)
https://github.com/processing/p5.js