Hi there!
I was looking at download p5 to use locally and I can't seem to find it.
I started with looking to download 1.0.0 from cloudflare but it's serving the wrong version.
So I looked in the https://github.com/processing/p5.js/tree/main/lib expecting it to be there.
But no. So I downloaded the p5 repo and searched for p5*js and p5.js and it's not there too
I did manage to download it from https://github.com/processing/p5.js/releases/
Which seemed kind of hidden to me and I don't if it's a bug/broken
or something else (user problem: me :) )
hellonearthis
All 17 comments
I think "the library is missing" is just not right. It is right there in releases.
https://github.com/processing/p5.js/releases/tag/1.0.0
You can see that file drop commit here -- maybe it was a mistake, but maybe not, and the readme should just be updated.
https://github.com/processing/p5.js/commit/bf0e9aa5e5532a5efc802ac74e6086abdebf2e4e#diff-eccec67c712f3fdf3dfe1c0a5397edde
After all, most software is built and released, not checked in to its own repo.
That said, the cloudflare bug seems like a big deal. I'd either retitle your issue about that or open a separate issue about "Cloudflare 1.0 loads 0.10.2" -- because that is a clear problem.
jeremydouglass
on 27 Apr 2020
It looks to me like this is the offending commit to cloudflare -- although I'm not familiar with their infrastructure.
https://github.com/cdnjs/cdnjs/tree/master/ajax/libs/p5.js/1.0.0
So a couple months ago a bot checked in the p5.js 0.10.2 files to their CDN repo on the /1.0.0 path.
Where does cloudflare get the files? Not this repo's releases, I guess, unless they grabbed a bad release in February that has since been changed. Do they get it from someplace that this project configures / controls? @lmccart
jeremydouglass
on 27 Apr 2020
I think this happened due to an error in the build process when we posted 1.0.0. The best way to resolve it would be to make a patch or minor release.
lmccart
on 27 Apr 2020
Quick follow-up If the minor release is to 1.0.1 and it gets picked up, won't that mean that the CDN caches a bad version of 1.0.0 forever?
jeremydouglass
on 27 Apr 2020
yes, I don't know if there's a way to fix the CDN, it reads from npmjs which can't be edited. maybe submitting a manual pull request?
lmccart
on 27 Apr 2020
maybe submitting a manual pull request?
Sure -- are the canonical artifacts that I should put in that PR currently in this repo's 1.0.0 release download?
jeremydouglass
on 27 Apr 2020
I'm sorry I'm not quite sure what "canonical artifacts" are, but the correct library files are posted here: https://github.com/processing/p5.js/releases/tag/1.0.0
lmccart
on 27 Apr 2020
I meant, if I post the stuff from the release, is it the right stuff, or is it also bad stuff.
jeremydouglass
on 27 Apr 2020
Great -- I'll try to make a PR as soon as I can, later today at earliest. If anyone else wants to first, go ahead. Looks like the cdnjs repo is over 10GB70GB on disk -- time for a shallow clone, but most PRs seem to go through fast.
jeremydouglass
on 27 Apr 2020
ah got it, the right stuff :)
thank you!
lmccart
on 27 Apr 2020
What a headache. Finally got a commit made against cdnjs, and in the diff it looks like the version number strings are the only difference. Anyhow, I'll ping you on the PR -- they really want authors/core developers signing off on requests.
jeremydouglass
on 28 Apr 2020
Great -- sign off on issue / PR here:
https://github.com/cdnjs/cdnjs/issues/13912
https://github.com/cdnjs/cdnjs/issues/13913
jeremydouglass
on 28 Apr 2020
wow, I didn't realize it was only the version number that got screwed up. well, thank you for looking into it and submitting the fix!
lmccart
on 28 Apr 2020
Mentioned back in #4336 it is the same case as the version on jsDelivr (the code is 1.0.0 just the version string still says 0.10.2) but I imagined it would be even more impossible for jsDelivr to be able to update it to say the right version string since they reflect NPM more directly than cdnjs.
Ultimately it's not a big problem as just the header comments is wrong and this shouldn't affect users' code adversely.
limzykenneth
on 28 Apr 2020
@limzykenneth Thanks so much, sorry I didn't find that earlier issue. While the code may be the same, I'd appreciate a 1.0.x latest release with a correct header (e.g. 1.0.1, whatever) if possible to minimize confused support questions.
The other reason is that the p5.js web editor is currently running the version from October. I have a PR for it open, but it points to 1.0.0 -- it would be nice to make that PR 1.0.1 (or whatever) and not fix a bug with a smaller bug.
jeremydouglass
on 28 Apr 2020
@jeremydouglass sorry for the runaround, thanks for trying to make the change on cdnjs! we will work on getting a 1.0.1 release out soon. thanks for all your help on the forum and beyond. :)
lmccart
on 28 Apr 2020
since we cannot revert this,
and it will be fixed on the next release of p5.js
i am closing this issue
montoyamoraga
on 6 May 2020
Related issues
aparrish
路
3Comments
stalgiag
路
3Comments
ogoossens
路
3Comments
swirly
路
3Comments
b0nb0n
路
3Comments
Most helpful comment
@jeremydouglass sorry for the runaround, thanks for trying to make the change on cdnjs! we will work on getting a 1.0.1 release out soon. thanks for all your help on the forum and beyond. :)