P5.js: push()/pop() documentation - missing functions

[catarak]

Nature of issue?

• [x] Found a bug
• [ ] Existing feature enhancement
• [ ] New feature request

Most appropriate sub-area of p5.js?

• [ ] Color
• [x] Core/Environment/Rendering
• [ ] Data
• [ ] Events
• [ ] Image
• [ ] IO
• [ ] Math
• [ ] Typography
• [ ] Utilities
• [ ] WebGL
• [ ] Other (specify if possible)

Which platform were you using when you encountered this?

N/A

Details about the bug:

• p5.js version: 0.9.0
• Web browser and version: N/A
• Operating System: N/A
• Steps to reproduce this:
  

Hi! I noticed on the documentation for push() that it lists a few functions that change the style/transformation of a p5 application:

push() stores information related to the current transformation state and style settings controlled by the following functions: fill(), stroke(), tint(), strokeWeight(), strokeCap(), strokeJoin(), imageMode(), rectMode(), ellipseMode(), colorMode(), textAlign(), textFont(), textSize(), textLeading().

However, it seems like this is missing a bunch of functions. Ones that come to mind are translate(), rotate(), and scale(), and there are probably other ones that aren't coming to mind at the moment. Maybe these functions should be added to that list?

[catarak]

Looking through the p5.js reference, other functions that are missing:

• noFill()
• noStroke()
• smooth()/noSmooth()
• bezierDetail() and curveDetail()
• everything under "Transform": applyMatrix(), resetMatrix(), rotate(), rotateX(), rotateY(), rotateZ(), scale(), shearX(), shearY(),translate()
• noTint()
• noiseDetail() and noiseSeed() (...are these affected by push()/pop()?)
• randomSeed() (...again, is this affected? i don't even know)
• angleMode()

I don't feel confident that this is everything (this doesn't include any webgl mode stuff), but I figured it would be useful to at least try to compile a complete list.

[lmccart]

thanks @catarak this is super helpful, will add!

[aferriss]

I think most of the work @sanketsingh24 and I did this summer for GSOC is also missing from the push() docs. Off the top of my head that would be:

• emissiveMaterial()
• specularColor()
• frustum()
• spotLight()
• falloff()

[imrishabh18]

Hi guys, I am a beginner can i work on this issue ?

[outofambit]

@imrishabh18 yes feel free! i'd recommend just doing docs for one or two functions in your first PR. thank you!

[imrishabh18]

@outofambit I have updated the documentation of couple of functions from the structure.js file but when running in the local development setup.The updated text is not showing up,

[limzykenneth]

@imrishabh18 Do you mean the local preview of the documentation in p5.js repo? If so can you file the PR anyway and I'll check if that is working as inteded. Thanks.

[J-888]

Currently working on it (WIP)

• [x] noFill()
• [x] noStroke()
• [x] translate()
• [x] rotate()
• [x] scale()
• [ ] smooth()/noSmooth(): can't manage to preview the difference properly to ensure push/pop works
• [x] applyMatrix()
• [x] resetMatrix()
• [x] shearX()
• [x] shearY()
• [x] noTint()
• [ ] noiseDetail(): can't manage to get it working with push() and pop()
• [x] noiseSeed()
• [ ] randomSeed(): can't manage to get it working with push() and pop()
• [ ] emissiveMaterial()
• [ ] specularColor()
• [ ] frustum()
• [ ] spotLight()
• [ ] falloff()

Pretty sure this are WEBGL:

• [ ] bezierDetail(): can't manage to get it working with push() and pop()
• [ ] curveDetail(): can't manage to get it working with push() and pop()
• [ ] rotateX()
• [ ] rotateY()
• [ ] rotateZ()

[Prasad-Chaudhari]

This issue has been merged. you can close it right ?

[stalgiag]

@Prasad-Chaudhari yes thank you!