P5.js: webgl: 'mixedMode' manual calls `normalMaterial` incorrectly

Created on 6 Mar 2019  路  8Comments  路  Source: processing/p5.js

normalMaterial() doesn't take these parameters:
https://github.com/processing/p5.js/blob/b2d1abce3ab5ebdeeb93558645405072521eaa13/test/manual-test-examples/webgl/mixedMode/sketch.js#L16

webgl help wanted beginner
Source
picture Spongman
👍1

All 8 comments

To do: fix the call to normalMaterial in the mixedMode manual test to follow the current proper usage (hint: no arguments)

stalgiag picture stalgiag on 7 Mar 2019
👍1

Has anybody claimed this? If not I would like to take this issue.

dasubermanmind picture dasubermanmind on 8 Mar 2019
👍1

great! go for it @EOstling !

stalgiag picture stalgiag on 8 Mar 2019

@EOstling if you not started yet I would also like to work on this. :smile:

Janglee123 picture Janglee123 on 10 Mar 2019

@Janglee123 If you are still interested this issue is accepting new pull requests again. Just to clarify, the only thing that should be done here is the removal of the arguments for normalMaterial() in this manual test example.

stalgiag picture stalgiag on 2 Apr 2019

@stalgiag Can I work on this? I already had a PR for this issue.

ghost picture ghost on 2 Apr 2019

Yep go for it @ashwathbhat !

stalgiag picture stalgiag on 2 Apr 2019

@stalgiag #3660 fixes this issue.

ghost picture ghost on 2 Apr 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

kappaxbeta picture kappaxbeta  路  3Comments
slowizzm picture slowizzm  路  3Comments
b0nb0n picture b0nb0n  路  3Comments
ghost picture ghost  路  3Comments
stalgiag picture stalgiag  路  3Comments