P5.js: Feature request: lights() function from Processing

[EndBug]

Nature of issue?

• [x] New feature request.

Most appropriate sub-area of p5.js?

• [x] Lights, Camera

New feature details:

In Processing there's a function (lights()) that quickly creates a good light effect. You can reproduce it in p5, but it's not as easy and quick as lights().
It would be good to have this function in p5 too.

[Spongman]

this is part of #2547

[EndBug]

Oh, sorry, I didn't see that.
I'm glad that someone is trying to add this function, are you going to split it and try to pull request again?

[kjhollen]

Someone can take this on by creating the new method in src/webgl/p5.RendererGL.js and just having it call this.ambientLight(128, 128, 128) and this.directionalLight(128, 128, 128, 0, 0, -1) to match the Processing behavior, more or less. some adjustments to the direction might be necessary.

[Spongman]

you can just take the code from #2547. it's already tested and working.

[IceDune]

@EndBug @Spongman @kjhollen , can i work on this pls?

[stalgiag]

Help is still needed with this. The todo is to add a function called lights
src/webgl/p5.RendererGL.js that calls the other light functions as @kjhollen explains above. #3112 can be looked at for some clues on how to do example docs and manual tests, but the method only needs to do what is outline in @kjhollen 's comment above.

[EndBug]

Hi guys! Seeing the last comment and the interest that this issue gained I decided to try it myself with PR #3553
At the moment works in Node 10 but has failed the test for Node 8: can someone help me figure out why?

[stalgiag]

Hi @EndBug this was unrelated to your code. I restarted the build. This time it was successful. I will open an issue. If this happens again restart the Travis CI build.