P5.js-web-editor: Internationalize mobile text

Created on 19 Aug 2020  Â·  7Comments  Â·  Source: processing/p5.js-web-editor

Currently, all texts on mobile views are hard-coded.
Use i18n to move these values to the translations file.
Bonus: Provide missing translations

good first issue

All 7 comments

btw, you can access the translations on desktop by adding the env variable TRANSLATIONS_ENABLED=true to your .env file.

I did some thinking about the design for switching the language, and this is what I have so far:
Screen Shot 2020-08-19 at 2 51 12 PM

I was thinking it could be in the dropdown menu, which would then open a popup that is similar to this:
1_msQUOeOtNhqKYi5tvSbZ2w

I'm not totally happy with this but I wanted a jumping off point. I was also messing around with the Desktop design to see if that would help generate ideas, which I've settled upon this right now (I'm gonna open a PR and ask Andrew and Omar for feedback):
Screen Shot 2020-08-19 at 2 58 17 PM
Screen Shot 2020-08-19 at 2 58 12 PM

In the mobile design, if possible, I would like to (1) have it be clear which language is selected, and (2) not have to open an additional popup.

I think adding a translation icon is very helpful

I think adding a translation icon is very helpful

Okay! How would the icon fit into the design?

I think to the left of the language name / dropdown title is a good idea!
On mobile, it can go to the left of the Language dropdown item

Edit: The <Dropdown /> Component has a <MaybeIcon /> component inside meant for this use case exactly. It was commented out because the styling isn't quite there yet, but you can use it!

Screen Shot 2020-08-21 at 2 47 13 PM
Screen Shot 2020-08-21 at 2 42 55 PM

Just throwing out another language selection idea :)

I love it!! Looks super nice ✨

Was this page helpful?
0 / 5 - 0 ratings

Related issues

aparrish picture aparrish  Â·  5Comments

aferriss picture aferriss  Â·  5Comments

andytilia picture andytilia  Â·  4Comments

byfelipesanchez picture byfelipesanchez  Â·  4Comments

jeremydouglass picture jeremydouglass  Â·  4Comments