P5.js-web-editor: Folder can be renamed to "" empty string

[Marton6]

Nature of issue?

• Found a bug

Details about the bug:

It is possible to clear the name of a folder by renaming it to "" and files can be renamed to only contain a valid extension (".js", ".css" etc.).
Moreover two or more folders with an empty name ("") can be contained in the same folder which will probably cause issues.

• Web browser and version: Chrome 71.0.3578.98
• Operating System: Windows and Linux
• Steps to reproduce this bug:
  
  
  
  1. Create a folder with a proper name.
  
  
  2. Click rename in the file navigator.
  
  
  3. Clear the name of the folder and click outside of it.
  
  

[siddhant1]

Looks like a bug to me , will fix this soon!

[catarak]

thanks for reporting! this is a bug and i can reproduce.

[siddhant1]

@catarak I think just adding a length cap might work?

[siddhant1]

I think as discussed on https://github.com/processing/p5.js-web-editor/pull/962#issuecomment-475330642 we should also add some validations at the backend and s3

[catarak]

i think there should be frontend and backend validations.

[olalekanteeblaze]

I'm a first time contributor, is this still open for me to work on?

[siddhant1]

Hey sure , go for it ! What you need to do to counter this one.

1. Add backend model level validations for folder name
2. Add a front end validation or some sort of min length validation
3. I think we have some prs already doing the 1 , you can pick up (2).

If you have any doubt , most people here will be happy to help(or just tag me).
Congratulations of your first oss project.
Cheers!