P5.js-web-editor: Negative Font Size

[Janglee123]

Nature of issue?

• [x] Found a bug
• [ ] Existing feature enhancement
• [ ] New feature request

• Web browser and version: Firefox 62.0 (64-bit)
• Operating System: Linux (Solus)
• Steps to reproduce this: Go to website and decrees font size

Details about the bug:

Recently I found that editor font size can be negative

[catarak]

Thanks for reporting! We probably shouldn't allow that, should we 😄 It probably makes sense to have some lower limit like 8px or something, and also an upper limit.

[bhawesh96]

This issue can be closed right?

[Janglee123]

@bhawesh96 No , I just started working on it but if you want you can work on it

[bhawesh96]

@Janglee123 Alright, I'll do it.

[bhawesh96]

How should the behaviour be? Should the buttons be disabled upon reaching the extreme limits?
Need to handle the case when one enters a font size less than the minimum limit directly into the <input> field.

[Janglee123]

Can you make it disappeared at limits ? You can ask it to @catarak

[bhawesh96]

IMO, making it disappear won't be a nice UX.

[catarak]

@bhawesh96 i agree, i don't think making the buttons disappear is a nice UX! i think what should happen is that once a user has the minimum/maximum size selected, then clicking the -/+ buttons won't do anything. you could disable the buttons (only the - button for minimum value, only the + button for maximum value) too.

i also noticed that you can set the indentation amount to negative values too. maybe it would be good to also give this a smart minimum and maximum value? like 0-6? i think it makes sense to fix this as part of this ticket.

[bhawesh96]

Disabling the buttons do not make the button _look_ disabled as onHover CSS remains. Hence, as a user, I might just keep clicking the button since I'm not being notified about the minimum / maximum value.

[catarak]

we could add a disabled style!

[bhawesh96]

@catarak This issue can be closed.

[catarak]

@bhawesh96 thanks!