Outline-client: The @ symbol in the password will report an error

[whg517]

The password contains the @ symbol, USES the shadowsocks-windows generated server configuration, and imports it on the android phone, indicating that the configuration access key is invalid.

The android client is downloaded from shadowsocks.org.

https://github.com/Jigsaw-Code/outline-releases/blob/master/client/Outline.apk?raw=true

[joeytwiddle]

Can confirm this bug. The example on shadowsocks.org suggests that @ is valid inside a password, even unescaped in the URI:

ss://bf-cfb:test/!@#:@192.168.100.1:8888

Therefore I think we should extract everything before the _last_ @, to separate the method+password from the host+port.

In shadowsocks_config.ts we could change:

- const atSignIndex = b64DecodedData.indexOf('@');
+ const atSignIndex = b64DecodedData.lastIndexOf('@');

Presumably that would fix it.

[alalamav]

@whg517, thanks for reporting this issue.
@joeytwiddle, the fix looks reasonable to me - would you be amenable to making the change in outline-shadowsocksconfig?

[joeytwiddle]

Fixed by that merge. Can be closed!

[trevj]

@joeytwiddle Apologies, we never updated the dependency lists to pull in this fix.

I just created this release:
https://github.com/Jigsaw-Code/outline-shadowsocksconfig/releases/tag/v0.0.9

And two PRs to pull it in:

• https://github.com/Jigsaw-Code/outline-client/pull/529
• https://github.com/Jigsaw-Code/outline-server/pull/402

The fix will go out in the next release. Many thanks again for the fix!