Osu: red tint layer displays even though no fail is enabled

[enoslayd]

Describe the bug: the red tint layer displays when failing even though no fail is enabled. doesnt happen to stable though. feel free to close if intentional

Screenshots or videos showing encountered issue:
stable w/ no fail

stable w/o no fail

lazer w/ no fail (std)

Lazer w/ no fail (mania)

osu!lazer version: 2020.418.0

Logs: not needed???

[peppy]

Not sure this is so bad..

[LittleEndu]

In-fact stable not showing the red tint when you use NF and not showing misses when you use RX is pretty annoying and not fun at all.

[Game4all]

I was aware of these cases when I PR'ed , but decided to keep them for a follow-up PR to match stable behaviour. Looks like the direction for this is to display the tint regardless of the current mods but I guess it may be interesting to get other opinions on that behavior change compared to stable?

[LittleEndu]

Speaking of other opinions, mania might need the red tint to come from left and right side. But that should be tracked in another issue.

[Coppertine]

I would think that having the red tint on something with NF would confuse the player as they know they are not going to have low HP since there technically is no HP in the mod.

[enoslayd]

In-fact stable not showing the red tint when you use NF and not showing misses when you use RX is pretty annoying and not fun at all.

i agree about rx but the no fail should not display the tint imo

[enoslayd]

Speaking of other opinions, mania might need the red tint to come from left and right side. But that should be tracked in another issue.

very agree on this

[bdach]

While I don't think this is bad either, maybe the tint should tie into the "Show health display even when you can't fail" setting?

[peppy]

Sounds good.