Osu: Toolbar should stay hidden when the user hides it

[Joehuu]

Pressing CTRL + T hides the toolbar (when shown), but when navigating most screens it shows back and that makes the shortcut useless in this sense.

This may be also good for stable users who think the lazer ui has many elements on screen or just use shortcuts. Most overlays on the toolbar can be accessed using shortcuts already.

[Volnetiks]

Well, gonna fix it, do you have the list of the screens that make the toolbar back?

[Game4all]

Instead of applying the fix per screen, you may want to directly fix the screen logic behind this located in OsuGame https://github.com/ppy/osu/blob/5459b7e7da2d1de2b5e34d2541f17b85e8ac61b3/osu.Game/OsuGame.cs#L945-L952

[Volnetiks]

Thanks, i was looking for it, but cant find it, am gonna work on it

[Volnetiks]

Well, it has been fixed, it will be in my next and first pull request

[integerrr]

I’ve replaced the entire if-else block to just running Toolbar.Show(); and it seems to do the trick, not sure if this is logically sound though.

[Volnetiks]

I’ve replaced the entire if-else block to just running Toolbar.Show(); and it seems to do the trick, not sure if this is logically sound though.

I have replaced the else by an else if, it works and sounds logical

[integerrr]

Can I have a look at your implementation? I couldn’t find it in your repo

[bdach]

We can discuss the code when the PR is opened.

[Volnetiks]

Well, I only have this commit, but I can open the pr, or send the code here, as u prefer

[TheWildTree]

Opening a PR is fine I suppose.

[bdach]

Issues aren't chat rooms - please keep idle chatter to a minimum.