Osu: Better offline support

Created on 1 Jan 2020 · 4Comments · Source: ppy/osu

Opening as an epic issue to group together other outstanding issues.

There are a few places where offline isn't supported in the best way (blank overlays, endless spinners...) Below is a (currently non-exhaustive) list of known issues associated with being offline:

[ ] Loading animations not stopping (#933)
[ ] Non-functional chat (#3024)
[ ] Non-functional direct (#4550)
[ ] Non-functional changelog (reported as crashing in #7416, crashes no longer)
[ ] Non-functional room browser (#8803)

Latest general direction seems to be blocking access to online-only views if possible and displaying placeholder text similar to leaderboards if not, but that might have changed in the meantime so I'd appreciate corrections if it has.

epic online

Source

bdach

👍3

Most helpful comment

Regarding the implementation of this, I have an idea that could work out and hopefully make offline support pretty straightforward for upcoming online API components, by implementing a container that handles whether to show the content or the login placeholder:
```
SomeAPIComponent:
OnlineContainer:
Box

// Box will show up if user is logged in, else the placeholder (implemented inside OnlineContainer) will show up.

frenzibyte on 5 Jan 2020

👍4

All 4 comments

I am not sure why we use epic issues instead of enabling projects.

mcendu on 2 Jan 2020

Projects are useful for a standard agile flow, which this is not.

peppy on 2 Jan 2020

Should all online overlays which require the user to be logged in exhibit this same behaviour ? If yes, logic could certainly be abstracted in a shared overlay class.