Osu: Crash when chatting with yourself

Created on 2 Jun 2019  路  4Comments  路  Source: ppy/osu

Describe the crash: There's still a way to chat with yourself; and if you try to open that chat, the game instantly crashes.

  1. Open the chat
  2. Send a message
  3. Right-click your name and then click "Start Chat"

Screenshots or videos showing encountered issue: https://streamable.com/c7nh5

osu!lazer version: 2019.530.0

Logs:
runtime.log
performance-gamethread.update.log

overlay-chat good-first-issue

Most helpful comment

The best solution here would be to disable (or hide) the ability to open a chat when the target is yourself. There should also be a second check in the ChatManager's channel open code to block the operation (doing nothing instead), just in case the user got around the menu items being disabled.

All 4 comments

Should probably be disallowed.

@peppy I see this has been marked as a good first issue. Can I take it? 馃檪

_(Also, I don't remember seeing anywhere in the contributing part of the README so I'll ask: should I open a "WIP" (Work In Progress) pull request while I work on anything?)_

PR's are usually opened with your result. WiPs happen if you need opinions on details, are stuck or there are some issues found afterwards.

The best solution here would be to disable (or hide) the ability to open a chat when the target is yourself. There should also be a second check in the ChatManager's channel open code to block the operation (doing nothing instead), just in case the user got around the menu items being disabled.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

smileyhead picture smileyhead  路  3Comments

Gonzalo-Bruna picture Gonzalo-Bruna  路  3Comments

skhrenov picture skhrenov  路  3Comments

stageosu picture stageosu  路  3Comments

GameBoyYeet picture GameBoyYeet  路  3Comments