osu!direct when a user isn't logged in

[kawaemon]

Describe the feature:
osu!direct when a user isn't logged in doesn't show anything even click search button. I think it should show something to tell the user not logged in.

Proposal designs of the feature:
I created a sample.

[kawaemon]

Should I create pull request which contains sample code?

[jorolf]

Pull requests are always welcome. However I'm not sure if this is the right way. Maybe we should show a message inside the center of the overlay instead or we could just block opening the overlay at all.

[kawaemon]

I agree. I'll wait for discussion!

[peppy]

@arflyte we need a general way of disabling/notifying the user they need to login to use some elements. do we have anything for this currently?

[arflyte]

Hmm, there's no design for now. I'll come up with something.

[Game4all]

How about graying out the whole overlay and displaying a placeholder message in the middle of it like it is done on Leaderboards on SongSelect ?

I tried implementing it on DirectOverlay on my fork
https://streamable.com/lejop

[LeNitrous]

Why not just simply gray out the osu!direct icon and not open the overlay in the toolbar?

[Gabixel]

and when the user clicks the button the game notifies him on the notification panel explaining that you need a supporter tag (maybe with a link sending to the support page)

[LeNitrous]

You no longer need supporter to use osu!direct @gabixdev

[alula]

wrong mention reeee

[smoogipoo]

For now it should use the same text as what's shown in the leaderboard.

[lucarou]

Hello,
As a part of our engineering studies, some friends and I tried our hands at this issue. Is this (in the screenshot) what is expected ?

[peppy]

Seems like a good start.

[lucarou]

We have finished adding an error message telling the user they should be connected in order to access the different overlays info to all overlays, and we have tested it. You can find the code at https://github.com/Remenems/osu. Even though we have read the contribution guideline, this is our first opensource experience. We understood that we had to wait for an eventual confirmation on your side before asking for a pr. Is this how things will go ?

[peppy]

You can PR as per normal. Please read some github guides if you're unsure of how to do this.

[bdach]

@lucarou as far as I can tell your changes are in your fork's master - please move them to a topic branch before PRing as mentioned in the contributing guidelines.

[Remenems]

Thank you, I will do it as soon as possible (I'm a coworker of @lucarou)