Osu: Keys are falling through texboxes

Created on 23 Apr 2018  路  6Comments  路  Source: ppy/osu

yes

framework-fix-required high-priority input
Source
picture tux1230

All 6 comments

No it does not

LittleEndu picture LittleEndu on 23 Apr 2018

Could this possibly be that bug where sometimes, while typing in a chat or any dialogue box, a key will open up a menu behind the chat? I'm not sure what the cause is, but I just got the same thing to happen, without pressing "d" specifically.

escolasticokid picture escolasticokid on 23 Apr 2018
👍1

I have had this bug occur before, however it really isn't reproducible. It happens infrequently. May just be race-conditions between textbox focus and global keybinds.

Frontear picture Frontear on 24 Apr 2018

You can reproduce this by pressing two keys perfectly simultaneously.

peppy picture peppy on 24 Apr 2018
👍1

Looked into this a bit, it's because OpenTKKeyboardHandler binds to KeyDown while GameWindowTextInput binds to KeyPress.

KeyDown is called before KeyPress.

So all that's required is for the update thread to luckily pull a new input state from the handler, and propagate that input down, prior to KeyPress being called.

smoogipoo picture smoogipoo on 7 May 2018
👍1

Seems to have regressed.

peppy picture peppy on 30 May 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

lauthaiming picture lauthaiming  路  3Comments
Moltanicaa picture Moltanicaa  路  3Comments
GameBoyYeet picture GameBoyYeet  路  3Comments
Lerkeer picture Lerkeer  路  3Comments
Joehuu picture Joehuu  路  3Comments