Orleans: Migrate samples to 2.1

[sergeybykov]

The samples (https://github.com/dotnet/orleans/tree/master/Samples) are on 1.2.3 now. Shouldn't be to difficult to migrate them to 1.3.0.

[serbrech]

Here is the list of the sample projects to track progress :

• [x] Adventure
• [x] AdventureDotNetCli
• [x] AzureWebSample
• [x] Chirper
• [x] FSharpHelloWorld
• [ ] GPSTracker
• [x] HelloWorld
• [ ] Presence
• [ ] ServiceFabric
• [ ] StorageProviders
• [ ] TicTacToe
• [ ] Tutorial.Minimal
• [ ] TwitterSentiment
• [ ] UnitTesting.Minimal
• [ ] VBHelloWorld

It also looks like I'll need to update the visual studio version because of tooling dlls referencing vs11 paths.

[serbrech]

Could you take a quick look at the package.config here? More packages had updates than I expected :

https://github.com/serbrech/orleans/commit/c02f48b0d234f0cbd1050ab66ad46d69386391c9#diff-0bf3cb56d1907d0d2ab758ef9246ade2

See in particular all the System.*
Reason for that is the new dependency on System.Collection.Immutbale, which suggested an update to all the other ones too.
Just want to be sure before I proceed with all the other sample projects.

And it looks like because the setup project was using Reflection, it pulled NETStandard.Library and even more stuff :

https://github.com/serbrech/orleans/commit/c02f48b0d234f0cbd1050ab66ad46d69386391c9#diff-6726e008481b77b041428715da25450a

[attilah]

Thanks for taking this issue! ;-)

As a rule of thumb we require the lowest dependency version from all packages, so please - if for other dependencies it is not a requirement - don't upgrade to "latest and greatest" :-) stick to the versions of packages what Orleans is using in its current master branch (which always will be the next release).

[serbrech]

Oh, that's not closed yet though, I'll keep working through the different Samples.
@attilah

[attilah]

I don't know why was this closed :-O

[jdom]

Thanks a lot for doing this. BTW, we plan to release 1.4.0 really soon though, does it make sense to wait 1 week until it's released and update to it instead?
Otherwise, you can also run Build.cmd, and that would generate 1.4.0 packages locally so you can reference them (there is now a nuget.config that will automatically pick them up). Check out HelloGeoSample for an example doing this.

[serbrech]

after struggling with the first couple projects, I know exactly which packages need to be updated. So I'll try to write a script to run the appropriate nuget updates commands, and the subsequent packages.config edits.
That should cover 90% of the updates, and it will help for future releases too.

[serbrech]

so, I have a solution that I will finish tomorrow, but it would be so much easier if this was implemented in nuget :
https://github.com/NuGet/NuGet.Client/pull/1044.

Today, you can do : nuget.exe update MySolution.sln -Id "MyPackage"

And that will update the package and all its dependencies
The problem is that nuget updates the dependencies to their latest, and we cannot tell it to resolve them to their lowest...
Concretely in Orleans' case, it means that we drag down System.Collections.Immutable 1.3.1 while the rest of Orleans uses 1.1.3.7.
And System.Collections.Immutable in version 1.3.1 has heaps of other dependencies that are really not needed in this case... Silly snow ball effect.

So instead, I update first the Immutables package to 1.1.37 manually, and then run the update commands, and nuget is happy...

Baah

[jokin]

I modified the HelloWorld.NetCore sample to work with the tech preview 3, Should we create an issue to track the migrations to 2.0.0 also?

[sergeybykov]

I think we can reuse (rename) this issue for migrating samples to 2.0.0. Once 2.0.0 is out, it won't make sense to migrate to 1.5.0 anymore.

[jokin]

ok, right now the netcore sample is not included in the issue, and the changes so it can buid with the preview are really straightforward ( https://github.com/jokin/orleans/commit/6ef8586c6f1cf331024162b6aa3ed9a45a3f7eb5 ) I Will watch the issue.

[sergeybykov]

Now that 2.1 is out, it also makes sense to leverage the new codegen package.