Origin: build 3.7.1 rpms

Created on 19 Jan 2018 · 33Comments · Source: openshift/origin

[root@oc-3 origin]# make build-rpms-redistributable
hack/build-rpm-release.sh
[INFO] Building Origin release RPMs with tito...
Creating output directory: /tmp/tito
ERROR: Error running command: git config --get user.name

Status code: 256

Command output: 

WARNING: user.name in ~/.gitconfig not set.

ERROR: Error running command: git config --get user.email

Status code: 256

Command output: 

WARNING: user.email in ~/.gitconfig not set.

OS_GIT_MINOR::7+
OS_GIT_MAJOR::3
OS_GIT_VERSION::v3.7.1+ab0f056
OS_GIT_TREE_STATE::clean
OS_GIT_CATALOG_VERSION::v0.1.2
OS_GIT_COMMIT::ab0f056
Tagging new version of origin: 0.0.1 -> 3.7.1-1.0.ab0f056
Traceback (most recent call last):
  File "/usr/bin/tito", line 23, in <module>
    CLI().main(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 203, in main
    return module.main(argv)
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 671, in main
    return tagger.run(self.options)
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 114, in run
    self._tag_release()
  File "/home/origin/.tito/lib/origin/tagger/__init__.py", line 40, in _tag_release
    super(OriginTagger, self)._tag_release()
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 136, in _tag_release
    self._check_tag_does_not_exist(self._get_new_tag(new_version))
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 555, in _get_new_tag
    return self._get_tag_for_version(suffixed_version, release)
TypeError: _get_tag_for_version() takes exactly 2 arguments (3 given)
[ERROR] PID 2032: hack/build-rpm-release.sh:30: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline` exited with status 1.
[INFO]      Stack Trace: 
[INFO]        1: hack/build-rpm-release.sh:30: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline`
[INFO]   Exiting with code 1.
[ERROR] hack/build-rpm-release.sh exited with code 1 after 00h 00m 06s
make: *** [build-rpms-redistributable] Error 1
[root@oc-3 origin]#

componeninternal-tools kinquestion prioritP3

Source

pennpeng

Most helpful comment

@arilivigni @tdawson Can we get 3.7.1 rpms built?

sdodson on 23 Feb 2018

👍7

All 33 comments

WARNING: user.name in ~/.gitconfig not set.

Look like you have to set user.name in the git configuration.

php-coder on 19 Jan 2018

@php-coder that's WARNING， not the error

pennpeng on 21 Jan 2018

Yes, but when it tries to get this value it fails:

ERROR: Error running command: git config --get user.email

php-coder on 21 Jan 2018

@php-coder hi，i use this command build 3.9 alpha3 that's ok ， but 3.7.1 is not

pennpeng on 21 Jan 2018

CC @stevekuznetsov

php-coder on 21 Jan 2018

Looks like you need a git environment with user name, etc.

stevekuznetsov on 22 Jan 2018

@php-coder @stevekuznetsov look the real error. when i config git environment ,same error:

[root@oc-3 origin]# make build-rpms-redistributable
hack/build-rpm-release.sh
[INFO] Building Origin release RPMs with tito...
Creating output directory: /tmp/tito
OS_GIT_VERSION::v3.6.1+efb0d59-8
OS_GIT_MINOR::6+
OS_GIT_COMMIT::efb0d59
OS_GIT_MAJOR::3
OS_GIT_TREE_STATE::clean
Tagging new version of origin: 0.0.1 -> 3.6.1-1.8.efb0d59
Traceback (most recent call last):
  File "/usr/bin/tito", line 23, in <module>
    CLI().main(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 203, in main
    return module.main(argv)
  File "/usr/lib/python2.7/site-packages/tito/cli.py", line 671, in main
    return tagger.run(self.options)
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 114, in run
    self._tag_release()
  File "/home/origin/.tito/lib/origin/tagger/__init__.py", line 40, in _tag_release
    super(OriginTagger, self)._tag_release()
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 136, in _tag_release
    self._check_tag_does_not_exist(self._get_new_tag(new_version))
  File "/usr/lib/python2.7/site-packages/tito/tagger/main.py", line 555, in _get_new_tag
    return self._get_tag_for_version(suffixed_version, release)
TypeError: _get_tag_for_version() takes exactly 2 arguments (3 given)
[ERROR] PID 12758: hack/build-rpm-release.sh:22: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline` exited with status 1.
[INFO]      Stack Trace: 
[INFO]        1: hack/build-rpm-release.sh:22: `tito tag --use-version="${OS_RPM_VERSION}" --use-release="${OS_RPM_RELEASE}" --no-auto-changelog --offline`
[INFO]   Exiting with code 1.
make: *** [build-rpms-redistributable] Error 1
[root@oc-3 origin]#

pennpeng on 23 Jan 2018

@dgoodwin does that stacktrace from tito ring any bells?

stevekuznetsov on 23 Jan 2018

It doesn't but that code saw some churn in the latest version and I've seen other issues around that which broke users and still need fixing. Is this with tito 0.6.11?

dgoodwin on 23 Jan 2018

@dgoodwin
hi,

[root@oc-3 ~]# rpm -qa | grep tito
tito-0.6.11-1.el7.noarch

pennpeng on 24 Jan 2018

no one help me????

pennpeng on 29 Jan 2018

@dgoodwin any thoughts here?

/unassign
/assign @dgoodwin

stevekuznetsov on 29 Jan 2018

Apologies I haven't had time yet to look and fix, it certainly looks like a bug in tito but I'm unclear why this is only surfacing here. Will try to find some time soon.

dgoodwin on 29 Jan 2018

👍1

Is that bug the reason why there are no 3.7.1 rpms in centos' paas repo yet?

ibotty on 3 Feb 2018

@ibotty i believe due to the issue which @dgoodwin said he will look into it ?

DanyC97 on 8 Feb 2018

any news @dgoodwin?

MansM on 13 Feb 2018

The issue is with the custom tagger in use by origin: https://github.com/openshift/origin/blob/master/.tito/lib/origin/tagger/__init__.py#L42 does not match the method signature for https://github.com/dgoodwin/tito/blob/master/src/tito/tagger/main.py#L570.

dgoodwin on 13 Feb 2018

@dgoodwin are you tackling the issue since it seems you know / are familiar with it or don't have the bandwidth ?

DanyC97 on 15 Feb 2018

Weird that that tagger issue pops up now, the OS line over a year old and the tito line is over 10 months old

MansM on 16 Feb 2018

@DanyC97 apologies I do not have the bandwidth, I tried to build origin while debugging but couldn't get it working offhand. For someone who is setup for origin building it should be a very quick Python fix, most likely just adding "release=None" to that method signature and you'll be good to go.

@MansM probably surfaced late because of delay in when it was released to Fedora/EPEL repos in December. Struggling to find time to maintain tito all around. :)

dgoodwin on 16 Feb 2018

sure, thanks @dgoodwin .
@stevekuznetsov done it already +1

With that said, who is the best person to tag so that it can push the rpms into the centOS repo ?

DanyC97 on 21 Feb 2018

@sdodson @michaelgugino anyone of you able to ping the person responsible with creating the rpms and who has access to publish them to centos repo?

thx for your help

DanyC97 on 23 Feb 2018

👍1

@arilivigni @tdawson Can we get 3.7.1 rpms built?

sdodson on 23 Feb 2018

👍7

+1 for these rpms to be built please

jameseck on 25 Feb 2018

@arilivigni @tdawson no chance to show some love to this issue ? everyone is been asking for the rpms for a very long time ....

DanyC97 on 6 Mar 2018

Sorry, we should have reported our progress on this.
This has been getting quite a bit of love, just not a final product.
Should be soon, hopefully within two days.

tdawson on 6 Mar 2018

Side note, team who is doing this on CentOS is completely volunteers now. Nobody is paid to do it.
Real Life is calling, and they will be stepping down (a) in a week and (b) in two months.
http://lists.openshift.redhat.com/openshift-archives/dev/2018-February/msg00015.html

tdawson on 6 Mar 2018

origin 3.7.1, and openshift ansible 3.7.35 are both available in the testing repository at
https://buildlogs.centos.org/centos/7/paas/x86_64/openshift-origin37/

We need some people to test these and make sure everything is ok. Once they have been tested, we will get them signed and in the released repositories.

tdawson on 6 Mar 2018

@tdawson thanks for the heads up with the announcement, i wasn't aware of that.

I'll speak internally and will try to get the ball rolling for testing origin 3.7.1
I might reach out to you privately if my current employer is willing for us to step up on taking the baton

DanyC97 on 8 Mar 2018

I'm just wondering what people do for critical security patches such as the ones mentioned in https://access.redhat.com/errata/RHSA-2018:0475 ?

I found the PRs that fix the issues (https://github.com/kubernetes/kubernetes/issues/60813, https://github.com/kubernetes/kubernetes/issues/60814) but these are in K8 and I'm not seeing the origin repo release branches contain recent commits. However, given that the above paid redhat subscription enables users to download updated packages, I assume there's a way to build origin with patched versions of k8? https://github.com/openshift/origin/blob/master/HACKING.md#using-hackcherry-pick ?