Origin: Add OWNERS files in different subsystems

[kargakis]

Already done upstream. This also has come up in discussions with @legionus

@liggitt @deads2k @smarterclayton @ncdc @bparees @mfojtik @pweil- @danmcp

[kargakis]

@soltysh @miminar @ironcladlou @derekwaynecarr @pmorie @knobunc

[ncdc]

+1, and also start assigning (automatically via bot?) PRs to the appropriate people for review

[derekwaynecarr]

+1 to both owners and assignee

On Friday, June 10, 2016, Andy Goldstein [email protected] wrote:

+1, and also start assigning (automatically via bot?) PRs to the
appropriate people for review

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/origin/issues/9273#issuecomment-225219481,
or mute the thread
https://github.com/notifications/unsubscribe/AF8dbFPW8_8Qi1qeL5aBLzWADpL4c7fAks5qKYbNgaJpZM4IzEfK
.

[deads2k]

Are we having trouble getting the right reviewers? I'm not opposed, but I wouldn't want it to be a solution in search of problem. Everyone with merge powers can assign their pull already, right?

[kargakis]

@legionus please remind me why you wanted this

On Mon, Jun 13, 2016 at 2:07 PM, David Eads [email protected]
wrote:

Are we having trouble getting the right reviewers? I'm not opposed, but I
wouldn't want it to be a solution in search of problem. Everyone with merge
powers can assign their pull already, right?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/origin/issues/9273#issuecomment-225562766,
or mute the thread
https://github.com/notifications/unsubscribe/ADuFfy1Nr4s7vsUf0ALpkVf2TGEqNXGYks5qLUfzgaJpZM4IzEfK
.

[smarterclayton]

OWNERS is useful for finding people to nag. Especially for new users.

On Mon, Jun 13, 2016 at 8:12 AM, Michail Kargakis [email protected]
wrote:

@legonius please remind me why you wanted this

On Mon, Jun 13, 2016 at 2:07 PM, David Eads [email protected]
wrote:

Are we having trouble getting the right reviewers? I'm not opposed, but I
wouldn't want it to be a solution in search of problem. Everyone with
merge
powers can assign their pull already, right?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/openshift/origin/issues/9273#issuecomment-225562766
,
or mute the thread
<
https://github.com/notifications/unsubscribe/ADuFfy1Nr4s7vsUf0ALpkVf2TGEqNXGYks5qLUfzgaJpZM4IzEfK

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/origin/issues/9273#issuecomment-225563824,
or mute the thread
https://github.com/notifications/unsubscribe/ABG_pw54DI6_sdstNPw1lxOKF5wfY5sYks5qLUlFgaJpZM4IzEfK
.

[soltysh]

+1 on the idea itself and I guess it will be in @stevekuznetsov area :D

[stevekuznetsov]

Since we can do multiple assignments now, do we want to just assign anyone that's an owner of a directory that the PR touches a file under?

[legionus]

I think yes.

[eparis]

I always feel like group assignment means that no one has responsibility...

[eparis]

I'll just believe @pweil- is gonig to hanve this issue and he's going to think that I will....

[stevekuznetsov]

Before we implement anything, first we need to have a conversation on what it means to assign someone a PR. In Origin today we don't even do that. Then I'd like to see a clear set of gains for an OWNERS impl in general and some consensus on what that sort of impl would look like.

[soltysh]

I'd assume it looks similar to the one k8s has. Iow. from the list of OWNERS for dir one is picked randomly and he gets the assignment. In general I think it's all about having someone getting the notification that there's such issue, so he can either work on it or re-assign to more appropriate person if such exists. That, I believe, is how it works for k8s, but @eparis will know better.

[eparis]

that is what we do, yes. The bot reads the OWNERS files in master, does a little heuristic to weigh people and then from the weight randomly picks the a person and assigns the PR to that person.

[stevekuznetsov]

Since that workflow currently lives under the purview of @danmcp -- two questions:

• is the way @danmcp is doing it now not sufficient? how so? how can this approach remedy that?
• @danmcp would you rather not do this yourself?

[eparis]

The OWNERS stuff upstream only touches PRs. And I know @danmcp looks at both PRs and issues. (we have minimal issue management, if you create a PR that fixes and issue, the issue gets assigned to you)

[danmcp]

@stevekuznetsov I actually haven't been assigning PRs for review all that much. We haven't actually had a high enough number of external PRs that we have needed an automated system either. I did happen to go through all the PRs today and found 5 or 6 of a few hundred PRs that were submitted externally that hadn't gotten enough attention in the last few months. It would have been useful to auto assign them. But I also gave myself a todo of going over these every day like I do issues from now on. I don't have any issue with automating the process a little certainly. But it's not a huge win right now given the incoming rate.

[pweil-]

This still takes me about ~5 minutes a day to assign out issue owners and PRs that are from external contributors. I'm all for adding and automating this if we adopt more of the kube processes but for now I think we can just close this.

[kargakis]

Added in https://github.com/openshift/origin/pull/15454