Org: Donate k8s service binding spec repo to the service catalog SIG

Created on 28 Apr 2021  路  27Comments  路  Source: kubernetes/org

New Repo, Staging Repo, or migrate existing


migrate existing repository https://github.com/k8s-service-bindings/spec

Requested name for new repository

service-binding-spec

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

arthurdm, nebhale, and jhvhs

If not a staging repo, who should have write access

arthurdm, nebhale, scothis, and sbose78

If not a staging repo, who should be listed as approvers in OWNERS

arthurdm, nebhale

If not a staging repo, who should be listed in SECURITY_CONTACTS

arthurdm, nebhale

What should the repo description be

Service Binding Specification for Kubernetes

What SIG and subproject does this fall under in sigs.yaml

This is a new subproject for sig-service-catalog called service-binding-spec

aregithub-repo

All 27 comments

@nikhita Can you help with this issue please?

Which SIG is taking over stewardship of it once its migrated? It needs approval from the leads before we can move to next steps.

/assign

Oh wait, @jhvhs you're a lead of service catalog, my bad^^;;;
It looks like the repo is generally good to go, but can you update the license boilerplate to reflect the Kubernetes one?
https://github.com/kubernetes/kubernetes/blob/master/hack/boilerplate/boilerplate.go.txt

Here are all the reqs for donation: https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md#rules-for-donated-repositories

@jhvhs In the issue description, the proposed repo name is "service-bindings-spec" whereas the sub-project name given is "service-binding-spec" in the last sentence. (bindings vs binding)

I think the sub-project name also should be changed to "service-bindings-spec".

Edit: typo

@mrbobbytables The license boilerplate is updated.

In the issue description, the proposed repo name is "service-bindings-spec" whereas the sub-project name given is "service-binding-spec" in the last sentence. (bindings vs binding)

I think the sub-project name also should be changed to "service-bindings-spec".

On second thought, I think it's better to align with the spec title where we use the singular form: Service Binding Specification. So, both the repo name and sub-project name could be service-binding-spec

cc. @nebhale @arthurdm

/assign

@baijum @jhvhs @nebhale There are a few more prerequisites before we can migrate the repo:

  • There is aNOTICE file at the root of the repo. This should not be present because NOTICE files have other legal connotations.
  • Please update README.md with the community, discussion and support + code of conduct sections as in the template - https://github.com/kubernetes/kubernetes-template-project#community-discussion-contribution-and-support
  • Charter change to include this PR needs to get merged: https://github.com/kubernetes/community/pull/5746

  • There are a few contributors who haven't signed the CNCF CLA. The rules for donated repos say that all contributors should have signed the CNCF Individual CLA or CNCF Corporate CLA. You will need to reach out to the contributors listed below and ask them to sign the CLA.

    • @pmacik
    • @nebhale
    • @scothis
    • @metacosm
    • @ianpartridge
    • @matthewpwilson
    • @jmesnil
    • @akashshinde
    • @AndrewJSchofield
    • @joicemjoseph

Note: if your name is listed above, could you please sign the CNCF CLA so that we can migrate the k8s-service-bindings/spec repo to Kubernetes? Instructions on how to sign the CLA can be found here. Thank you! :)

@arthurdm, @nebhale, @scothis, and @sbose78 - you are listed in the issue body for admin/approver access. To get this access, you need to be a part of the @kubernetes-sigs GitHub org. Can you please apply for membership?

PR: https://github.com/k8s-service-bindings/spec/pull/159

  • @pmacik
  • @nebhale
  • @scothis
  • @metacosm
  • @ianpartridge
  • @matthewpwilson
  • @jmesnil
  • @akashshinde
  • @AndrewJSchofield
  • @joicemjoseph

Updates:

  • pmacik - Signed
  • metacosm - Contacted (Update: Signed using Corporate CLA)
  • jmesnil - Contacted (Update: Signed)
  • akashshinde - Contacted (Update: Signed)
  • joicemjoseph - Contacted (Update: Signed)

@arthurdm Can you help with these contributors?

  • ianpartridge
  • matthewpwilson
  • AndrewJSchofield

@nebhale @scothis Not sure why your account shows that it's not signed. Can you check if the CLA account has linked with GitHub. From the FAQ

  1. I signed the ICLA with the wrong email, what do I do?

Neither the email on the ICLA (captured from you Linux Foundation ID profile when you signed) nor the current email on the profile matters for passing the GitHub check.

For a PR to pass, each commit must pass this check: the Github user that the commit is attributed to (based on a match between the commit authorship and Github profile) must be linked to a Linux Foundation ID user (on the "social network logins" tab), who is authorized by a signed ICLA and/or a CCLA.

@baijum how do I sign the CLA if I'm part of an organization that already has signed it?

  • There is aNOTICE file at the root of the repo. This should not be present because NOTICE files have other legal connotations.

@nikhita We need to add this file if we are not able to contact any of the contributors to sign the CLA, right? Is that going to be a post-migration activity?

I signed up the CLA

I should be signed now.

...I had signed in the past, maybe it was lost when I had multiple LF accounts merged.

@baijum how do I sign the CLA if I'm part of an organization that already has signed it?

@nikhita I am not sure how the organization CLA works. BTW, his commits have this email address [email protected]. I am not sure if that's causing the issue.

@AndrewJSchofield has left IBM, but should be able to still sign the CLA as an individual.

@matthewpwilson / @ianpartridge - can you please sign the CLA for your contributions to the k8s service binding spec?

CLA signed

@baijum how do I sign the CLA if I'm part of an organization that already has signed it?

@nikhita I am not sure how the organization CLA works. BTW, his commits have this email address [email protected]. I am not sure if that's causing the issue.

He has confirmed to me that he has signed in with his organization's credentials at https://identity.linuxfoundation.org/projects/cncf . I think that should be sufficient to be authorized.

Sure! Will do!

  • pmacik - Signed
  • metacosm - Contacted (Update: Signed using Corporate CLA)
  • jmesnil - Contacted (Update: Signed)
  • akashshinde - Contacted (Update: Signed)
  • joicemjoseph - Contacted (Update: Signed)

Update: All the contributors I contacted have signed the CLA.

@nikhita We need to add this file if we are not able to contact any of the contributors to sign the CLA, right? Is that going to be a post-migration activity?

While the rules say that, we've avoided adding the NOTICE file in the past because it's desirable to have all contributors sign the CLA. In the past, we've also waited for 2-3 months for all contributors to sign the CLA.

  • Applied for membership: kubernetes/org#2774
  • Signed the CLA under multiple identities

Please update README.md with the community, discussion and support + code of conduct sections as in the template - https://github.com/kubernetes/kubernetes-template-project#community-discussion-contribution-and-support

Completed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

codenrhoden picture codenrhoden  路  3Comments

szuecs picture szuecs  路  3Comments

epk picture epk  路  3Comments

cblecker picture cblecker  路  3Comments

lpabon picture lpabon  路  3Comments