Org: Migrate multicloudlab/cluster-api-provider-ibmcloud to kubernetes-sigs

[gyliu513]

New Repo, Staging Repo, or migrate existing

Migrate existing https://github.com/multicloudlab/cluster-api-provider-ibmcloud

Requested name for new repository

cluster-api-provider-ibmcloud

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

@gyliu513

If not a staging repo, who should have write access

I can set this up once we get migrated in.

If not a staging repo, who should be listed as approvers in OWNERS

We already have OWNER and OWNERS_ALIASES:

• https://github.com/multicloudlab/cluster-api-provider-ibmcloud/blob/master/OWNERS_ALIASES
• https://github.com/multicloudlab/cluster-api-provider-ibmcloud/blob/master/OWNERS

If not a staging repo, who should be listed in SECURITY_CONTACTS

We already have https://github.com/multicloudlab/cluster-api-provider-ibmcloud/blob/master/SECURITY_CONTACTS

What should the repo description be

Cluster API implementation for IBM Cloud

What SIG and subproject does this fall under in sigs.yaml

This is a new subproject for sig-ibmcloud called cluster-api-provider-ibmcloud.

Approvals

• sig-ibmcloud: https://groups.google.com/forum/#!topic/kubernetes-sig-ibmcloud/K61oVd5yxv0
• sig-cluster-life-cycle: https://docs.google.com/document/d/1Ys-DOR5UsgbMEeciuG0HOgDQc8kZsaWIWJeKJ1-UfbY/edit#
  
  
  
  • Please refer to meeting Wed 1 May 2019 - 10am Pacific
  
  

Additional context for request

[gyliu513]

@khahmed @spzala @nikhita

[bradtopol]

+1 I support this and hope we can move quickly to approve it

[cblecker]

/assign

@gyliu513 Can you please add me as an "admin" of the source repo please? I can start running through the pre-requisites to moving.

Do you have a specific time frame you're looking to get this migrated in?

[cblecker]

I currently see four contributors. I have verified CLA for the following users:

• @gyliu513
• @xunpan
• @jichenjc
• @morvencao

[cblecker]

Reviewing the approvals you've linked to, sig-cluster-lifecycle has deferred to sig-ibmcloud. The sig-ibmcloud e-mail was sent around the time that this was opened.

Please advise when there is sufficient sig consensus. Typically this is done with a consensus period (usually between 72 hours and a week, but solely at the sig's discretion). The idea is to ensure that the sig has consensus before adopting a piece of outside code.

[cblecker]

@nikhita @justaugustus Would one of you mind running a FOSSA scan?

[gyliu513]

@cblecker thanks for the quick response for this, really appreciate this! I have added you as admin for the project at https://github.com/multicloudlab/cluster-api-provider-ibmcloud/pull/100

I think I can get approval from @khahmed @spzala soon ;-)

[cblecker]

Oh, I don't need to be in an OWNERS file, what I need is direct GitHub admin access.

You can follow the directions here: https://help.github.com/en/articles/adding-outside-collaborators-to-repositories-in-your-organization, selecting "admin" at the last step when you are choosing a permission level.

[gyliu513]

@cblecker Done ;-)

Do you have a specific time frame you're looking to get this migrated in?

@cblecker it would be great if we can finish the migration early next week, we want to announce this in the coming KubeCon EU for sig-ibmcloud intro & deep dive.

[khahmed]

+1 I approve

[nikhita]

@nikhita @justaugustus Would one of you mind running a FOSSA scan?

Hmm, I'm not entirely sure how to run a FOSSA scan on a non-Kubernetes repo... @justaugustus probably knows about this better. :)

[dims]

I was able to run one @nikhita @cblecker
https://app.fossa.com/projects/git%2Bgitlab.com%2Fdavanum%2Fcluster-api-provider-ibmcloud/refs/branch/master/baf9978932fcef7570eebc3f08663f0ac35eb82a/issues/licensing?filter=policy_flag

There were 2 issues flagged, both in docker/docker repository (deep scan) and both of them were spurious as well. (and we don't import or use those files in this repo).

[gyliu513]

Thanks @dims , so no action is need from us for the FOSSA scan, right?

[dims]

@gyliu513 correct.

[spzala]

+1 from sig-ibmcloud

[spzala]

@cblecker thanks for the quick response for this, really appreciate this! I have added you as admin for the project at multicloudlab/cluster-api-provider-ibmcloud#100

I think I can get approval from @khahmed @spzala soon ;-)

Done. This is great! Thanks all @gyliu513 @cblecker @dims @nikhita

[mdelder]

👍 LGTM.

[cblecker]

Opened PR to get the initial teams created: https://github.com/kubernetes/org/pull/784

[cblecker]

Okay, so the only item remaining is explicit consensus from the sig.

@spzala @khahmed: Please advise when you feel the sig has had enough time to achieve consensus to adopt this code.

[gyliu513]

Wow, really great progress, thanks @cblecker !

I think sig-ibmcloud is ready to adopt this code, @khahmed @spzala , can you please help confirm? Thanks.

[spzala]

@cblecker thanks for moving it quickly!! The sig is under consensus. We have discussed this work in the sig in the past and have given enough time for members to vote so we are good to go from sig side. Thanks!

[cblecker]

The migration part is now done. The automation and stuff may take up to 24 h to run and set up things like branch protection and labels.

All direct collaborator access has been revoked. If direct write or admin access is needed, please submit PRs to add usernames to the provisioned teams:
https://github.com/kubernetes/org/blob/c3ce94d4b8b51fd232be3dcc352fc09d45e94db9/config/kubernetes-sigs/sig-ibmcloud/teams.yaml#L1-L11

Can you please also submit a PR to update sigs.yaml in the community repo with the details of this repository?

[gyliu513]

@cblecker just created a PR to add more maintainers at https://github.com/kubernetes/org/pull/785

For the PR of updating sig.yaml, do you mean adding the project to https://github.com/kubernetes/community/blob/master/sig-ibmcloud/README.md and also update https://github.com/kubernetes/community/blob/master/sigs.yaml#L1181 ? If so, I want to update it after the repo was created as it will request the link of the kubernetes-sigs ibmcloud repo, comments?

BTW: Who will help us to create the repo for cluster-api-provider-ibmcloud under kubernetes-sigs? ;-)

[nikhita]

If so, I want to update it after the repo was created as it will request the link of the kubernetes-sigs ibmcloud repo, comments?

@gyliu513 repo has already been migrated :)

Please see https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud. Also, https://github.com/multicloudlab/cluster-api-provider-ibmcloud will automatically redirect to the kubernetes-sigs repo.

[nikhita]

For the PR of updating sig.yaml, do you mean adding the project to https://github.com/kubernetes/community/blob/master/sig-ibmcloud/README.md and also update https://github.com/kubernetes/community/blob/master/sigs.yaml#L1181 ?

To answer this part -- yes, you'll need to add the repo to sigs.yaml and then run make generate. This will automatically update the readme. :)

[gyliu513]

Thanks @nikhita , created a PR for ibmcloud at https://github.com/kubernetes/community/pull/3669 , so I think we can close this issue now?

[nikhita]

@gyliu513 let's close this after the PR gets merged :)

[nikhita]

Closing since https://github.com/kubernetes/community/pull/3669 merged.

/close

[k8s-ci-robot]

@nikhita: Closing this issue.

In response to this:

Closing since https://github.com/kubernetes/community/pull/3669 merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.