We need a new kubernetes/cri-api (similar to kubernetes/csi-api or kubernetes/node-api)
cri-api
kubernetes
it is a staging repo.
it is a staging repo.
@dchen1107 @derekwaynecarr @dims
@dchen1107 @derekwaynecarr @dims
Container Runtime Interface (CRI) – a plugin interface which enables kubelet to use a wide variety of container runtimes
sig-node
Please prove you have followed the appropriate approval process for this new
repo by including links to the relevant approvals (meeting minutes, e-mail
thread, etc.)
closely related to the KEP being filed for dockershim : https://github.com/kubernetes/enhancements/pull/866
cc @dchen1107 @derekwaynecarr @mikebrow @resouer @ddebroy
Requested name for new repository
cri-api
nit.. suggest cri by itself, the api suffix should not be necessary
@mikebrow please see the existing patterns :) https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io
/assign
It's too early here so maybe I missed something :) but this'll also need approval from sig-arch since this is a core repo: https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md#core-repositories
Ack, i sent an email to them asking for approval:
https://groups.google.com/d/msg/kubernetes-sig-architecture/xtt1CbeSZzQ/mYQesFQTBAAJ
/approve
Note, @dims and @derekwaynecarr who are listed on this request are SIG Arch co-chairs as listed in https://github.com/kubernetes/community/tree/master/sig-architecture#leadership
@mikebrow please see the existing patterns :) https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io
Two thoughts... why repeat a pattern out of convention that has no useful function... container runtime interface - application programming interface is a long winded collection of TLAs that repeats the word interface. Coming from a TLA company working on OSS I get the appeal :-) But there is no need to say interface twice, since CRI is an API. Thus the pattern of naming the Interfaces as such is secure by just saying CRI. I suppose the one benefit of naming it CRI-API is we could then subsequently.. oh wait no can't think of one :-)
@mikebrow noted, we should rather spend time on figuring out what else we need to do (see example [1]) than bikeshed on the name. Having been through transitions of some software between DataPower / WebSphere / PureApplication / BlueMix / Softlayer brands in a previous life, this stuff is hard and let's keep the existing patterns.
We have +1 from me, @derekwaynecarr and @mattfarina So let's please go ahead with this.
Repo created https://github.com/kubernetes/cri-api :tada:
Note: The OWNERS and SECURITY_CONTACTS listed here will be directly published from staging in k/k. I have created https://github.com/kubernetes/org/pull/653 to not ask these values in the issue template for staging repos from now on.
Thanks a ton @nikhita
Only thing that's left now: https://github.com/kubernetes/community/pull/3518
Thanks a ton @nikhita !
https://github.com/kubernetes/community/pull/3518 merged \o/
/close
@nikhita: Closing this issue.
In response to this:
https://github.com/kubernetes/community/pull/3518 merged \o/
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Most helpful comment
/approve
Note, @dims and @derekwaynecarr who are listed on this request are SIG Arch co-chairs as listed in https://github.com/kubernetes/community/tree/master/sig-architecture#leadership