New Repo (?) (Migrating a directory out of https://github.com/kubernetes/test-infra)
kind would be ideal, it's the tool's name now, seems to not be in use elsewhere and is a good CLI / install path.
kind == Kubernetes IN Docker (see blow)
kubernetes-sigs -- this is a sig-testing project
e.g (at)example_user should have write access
approver and key contributor)kind reviewers currentlyThis is a SIG repository, I requested a vote by email and in the SIG weekly meeting for sig-testing:
Per the sig discussion, we've incubated this in test-infra under sig-testing, but we'd like to move it out (and in the future other parts of test-infra), and set up CI for it there without bogging down PRs to the test-infra config and other tools etc. We also need a way to version it back to kubetest which is in test-infra, so moving it out seems like the way to solve this.
To be done:
My only concern here is the extremely generic name.
@spiffxp @stevekuznetsov @fejta: Any comments on naming? Is this the best name for this tool/repo?
I'm open to alternatives if someone has a better one, @munnerz suggested it and I've actually not found anyone using it. It makes for a great little command line / go install. kind create, kind build node --type=bazel etc.
FWIW I also didn't think the name would be much of a problem being in @kubernetes-sigs rather than as a core project.
I'm fine with renaming it if we find that kind isn't the right name for it, but it's been discussed as kind thus far
I'm asking you guys though. It seems generic to me, but it's ultimately a sig decision. First come first serve in k-sigs.
Ok that makes sense to me. Do you mind if we keep the name for now? I think the sig is fine with it, we've discussed the project for a while now O(months) and not had any complaints about the name. I like it and haven't had any better ideas :-)
kind seems an appropriate name for the project and we have not heard any objections in the SIG while development has been underway. I don't see any similar names in the k8s ecosystem with a couple cursory searches, so it doesn't seem like the name collides with anything. +1 from me
SGTM. Will create tomorrow :)
Thanks @cblecker 馃槃
@BenTheElder is there a need for direct write access at this time (genuine question)? I've got you set up with top-level owners, and I've invited you all to the org. If we decide to leave it at OWNERS and find we need it later, we could add at that time.
Uh possibly not? I was planning to port over history with filter branch which I've not used before.
Let's see how far we can get for now, I'm a fan of our robot overlords :^) I hopefully don't actually need it. I may have to bug one of you at some point for more repo settings but we can sort that out when it happens :smile:
@BenTheElder my thought is, let's dog food the "no direct write access" model if we can. You should be able to port over history with a PR. It would be great to see where the rough patches of that model are.
https://github.com/kubernetes-sigs/kind/pull/1 not too bad, though README.md and OWNERS in the root make a lot of merge conflicts :sweat_smile:
DIR="kind" git filter-branch --prune-empty --subdirectory-filter "${DIR}" masterlast thing is getting sigs.yaml updated:
https://github.com/kubernetes/community/blob/bdf0c28d40ca04b8b5dd31c9946c1bf622195ef2/sigs.yaml#L1700-L1711
@spiffxp @stevekuznetsov @fejta: How would you like to handle that?
Is everything a subproject if it has it's own repo?
Is everything a subproject if it has it's own repo?
It depends. There are subprojects like kubernetes-csi that span multiple repos, node-problem-detector that is a single repo root, and kubernetes-cloud-provider which spans multiple subdirs in a repo with no root
Here, I think it makes sense for kind to be its own subproject.
/close
and it's in sigs.yaml now
@spiffxp: Closing this issue.
In response to this:
/close
and it's in sigs.yaml now
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Finally remembered to do this, sorry, video link is here: https://youtu.be/av3eFyyFryA
Updated the body above as well
Most helpful comment
SGTM. Will create tomorrow :)