Orchardcore: Consider listing code owners for this repository

Created on 21 Nov 2018  路  4Comments  路  Source: OrchardCMS/OrchardCore

When submitting a PR updating code you're not familiar with, it's not always easy to determine who's the right person it should be assigned to for review (e.g when modifying the modular middleware, chances are fairly high you'll want JTK to take a look :smile:).

To fix that, I suggest establishing a list of code owners who will be automatically pinged when code they own is updated by a PR: https://blog.github.com/2017-07-06-introducing-code-owners/

Needless to say, I'm applying to be one of the code owners of the OpenID module/core components :sweat_smile:

enhancement

All 4 comments

I agree, let's just add @jtkech at the root folder

I agree, let's just add @jtkech at the root folder

This means he'll have to review every submitted PR :smile:

I had a more fine-grained approach in mind. E.g:

  • Infrastructure/build files: @jtkech
  • Workflow components: @sfmskywalker
  • GraphQL module: @Jetski5822
  • OpenID components: @PinpointTownes

This means he'll have to review every submitted PR

I disagree 馃槈

Was this page helpful?
0 / 5 - 0 ratings