Operator-sdk: Add tests to ensure the gen-csv commands

Created on 7 Oct 2019  路  6Comments  路  Source: operator-framework/operator-sdk

What

  • Check what is missing and add tests to ensure the gen-csv commands for example operator-sdk olm-catalog gen-csv --update-crds
aretesting good first issue help wanted kinfeature olm-integration

Most helpful comment

We have some unit tests for the CSV scaffolding that do test the basic scenarios like new CSVs and updates to existing ones https://github.com/operator-framework/operator-sdk/blob/master/internal/pkg/scaffold/olm-catalog/csv_test.go

But we need to see what's missing in order to catch bugs like #2015 and #2017
/cc @estroz

All 6 comments

:+1: It has been on our plate to add unit tests for the components that make up gen-csv. It would definitely be good to add these.

We have some unit tests for the CSV scaffolding that do test the basic scenarios like new CSVs and updates to existing ones https://github.com/operator-framework/operator-sdk/blob/master/internal/pkg/scaffold/olm-catalog/csv_test.go

But we need to see what's missing in order to catch bugs like #2015 and #2017
/cc @estroz

Here are some of the things I've documented having to edit in my CSV after running gen-csv. I hope that is helpful. If I should open these as a different ticket, please say so....

Moved to #2071

Hi @flickerfly,

This task is about we add a test for the command which is implemented already, so you have been editing manually the CSV because the tool is not implemented to generated this fields and it would be out of the scope of this issue. Could you please open a new issue since the subject is not the same?

Really thank you.

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

It was done already. Closing with sorted out.
/remove-lifecycle stale

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lsalazar1 picture lsalazar1  路  4Comments

magescher picture magescher  路  3Comments

surajssd picture surajssd  路  3Comments

ffoysal picture ffoysal  路  3Comments

kristiandrucker picture kristiandrucker  路  5Comments