Openzeppelin-contracts: Minor refactoring of .circleci yaml?

[Luiserebii]

I wanted ask about: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/.circleci/config.yml

I think

  coverage:
    docker:
      - image: circleci/node:8

could simply take advantage of the alias defined earlier and use:

  coverage:
    <<: *defaults

Is there a reason why it doesn't?

Also, I was curious about perhaps adding an alias for:

      - checkout
      - restore_cache:
          <<: *cache_key_node_modules
      - *npm_install_if_necessary

Since it pops up everywhere. Would this be overkill?

Thanks,
Luiserebii~

[xinbenlv]

I have not used *defaults, not sure if it applies to only circleci config version 2.1. Feel free to try it. If it works, I would suggest this change

[Luiserebii]

Sure, ok, will try now!

[Luiserebii]

Just made a PR for this here: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/1885

[Luiserebii]

Closed by accident, apologies, haha.

[Luiserebii]

Closing as PR has been merged: #1885