Title: Add golang runtime support to default deployments
"golang": [
{
"kind": "golang:1.11",
"default": true,
"deprecated": false,
"attached": {
"attachmentName": "codefile",
"attachmentType": "text/plain"
},
"image": {
"prefix": "openwhisk",
"name": "actionloop-golang-v1.11",
"tag": "latest"
}
}
]
Use Ruby PR as reference: https://github.com/apache/incubator-openwhisk/pull/3725
--kind golang:x and prefix .goIssue opened here https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1004
Issue opened here https://github.com/apache/incubator-openwhisk-website/issues/343
cc @sciabarra ^^
Excellent. Glad to see this!
I think folks voted in mailing list for --king go:1.11 over --kind golang:1.11
So it needs to be
"go": [
{
"kind": "go:1.11",
"default": true,
"deprecated": false,
"attached": {
"attachmentName": "codefile",
"attachmentType": "text/plain"
},
"image": {
"prefix": "openwhisk",
"name": "actionloop-golang-v1.11",
"tag": "latest"
}
}
]
Submitted all the 4 PR required.
core repo PR merged: https://github.com/apache/incubator-openwhisk/pull/4093
deploy-kube repo merged: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/327
@daisy-ycguo Do you know if we need changes for wskdeploy?
The devtools PR is merged: https://github.com/apache/incubator-openwhisk-devtools/pull/172
core cli PR is merged now: https://github.com/apache/incubator-openwhisk-cli/pull/375
I need to check if wskdeploy needs to updated with the runtime
@sciabarracom You want to handle these also
I added items 5 and 6 above
Issue opened here https://github.com/apache/incubator-openwhisk-wskdeploy/issues/1004
Issue opened here https://github.com/apache/incubator-openwhisk-website/issues/343
All issues are closed now 馃帀
Most helpful comment
Excellent. Glad to see this!