Openwhisk: Controller should not return a payload for created and deleted entities

Created on 12 Feb 2018  路  5Comments  路  Source: apache/openwhisk

When creating entities, the controller should respond with just a status code, 200 OK or 201 CREATED, omitting the created entity from the response.

Similarly, when deleting entities a status code, 200 OK or 202 ACCEPTED, should be returned without including the deleted entity in the response.

controller good first issue help wanted

All 5 comments

Hi @dubee, @rabbah,
I am a beginner looking to contribute to OSS. Can I pick this issue?

@nitikagarw
Thank you for your help and welcome to the community :)

Welcome to the community @nitikagarw - when you complete your first PR send me a message on Slack and I'll send you an openwhisk coffee/tea mug or hoodie.

Hi @style95 @rabbah, Thank you for giving me the chance to contribute to OSS.

I spent some time familiarizing myself with the code and have created a Draft PR to know if I'm moving in the right direction.

I have two questions:

  • As we have the same function for PUT and POST, Do we need to make this change for both methods or only for the POST APIs?

  • What are your views about changing the HTTP Status of DELETE API to 204 from 200?

closing as done.
Thanks, @nitikagarw!

Was this page helpful?
0 / 5 - 0 ratings