Openui5: titleChanged Event not propagating across nested components correctly

[grahamrobbo]

OpenUI5 version: 1.80.0

Browser/version (+device/version): Chrome Version 84.0.4147.89 (Official Build) (64-bit)

Any other tested browsers/devices(OK/FAIL): No

Steps to reproduce the problem:

1. Use demo from @flovogt blog https://blogs.sap.com/2020/03/23/ui5ers-buzz-48-consuming-title-changes-of-nested-components/

1. Set target title property in BOTH _Root Component_ manifest.json and _Suppliers Component_ manifest.json.

{
    ...,
    "targets": {
        ...,
        "suppliers": {
            "type": "Component",
            "usage": "suppliersComponent",
            "title": "Root Component Supplier Title"
        },
    ...
}

{
    ...,
    "targets": {
        "list": {
            "type": "View",
            "id": "list",
            "type": "List",
            "title": "Supplier Component Supplier Title"
        },
    ...
}

1. Navigate to _Suppliers Component_ - then do browser refresh. Event titleChanged is propagated from _Suppliers Component_ to _Root Component_ as expected.

1. Remove title property from _Root Component_ manifest.json.

{
    ...,
    "targets": {
        ...,
        "suppliers": {
            "type": "Component",
            "usage": "suppliersComponent"
        },
    ...
}

1. Perform browser refresh. Event titleChanged is not propagated.

It seems the titleChanged event is only propagated when the _Root Component_ has the matching target title property defined.

[grahamrobbo]

I also found that title properties in _Root Component_ manifest.json not only have to be defined but also have to be unique or titleChanged event propagation does not work.

This works.

{
    ...,
    "targets": {
        ...,
        "suppliers": {
            "type": "Component",
            "usage": "suppliersComponent",
            "title": "A"
        },
        "categories": {
            "type": "Component",
            "usage": "categoriesComponent",
            "title": "B"
        },
        "products": {
            "type": "Component",
            "usage": "productsComponent",
            "title": "C"
        },
  ...
}

... this doesn't

{
    ...,
    "targets": {
        ...,
        "suppliers": {
            "type": "Component",
            "usage": "suppliersComponent",
            "title": "A"
        },
        "categories": {
            "type": "Component",
            "usage": "categoriesComponent",
            "title": "A"
        },
        "products": {
            "type": "Component",
            "usage": "productsComponent",
            "title": "A"
        },
  ...
}

[flovogt]

Hi @grahamrobbo ,
thanks for positing your described scenario.
We'll have a look.
Best Regards,
Florian

[flovogt]

Supplier Component Supplier Title

Hi @grahamrobbo, I executed the described steps. However, removing the title of the target in the root component does still propagating the title for me. Could you provide us your application code, please? So, we'll have a look on that.

[flovogt]

I also found that title properties in _Root Component_ manifest.json not only have to be defined but also have to be unique or titleChanged event propagation does not work.

This works.

{
    ...,
    "targets": {
        ...,
        "suppliers": {
            "type": "Component",
            "usage": "suppliersComponent",
            "title": "A"
        },
        "categories": {
            "type": "Component",
            "usage": "categoriesComponent",
            "title": "B"
        },
        "products": {
            "type": "Component",
            "usage": "productsComponent",
            "title": "C"
        },
  ...
}

... this doesn't

{
    ...,
    "targets": {
        ...,
        "suppliers": {
            "type": "Component",
            "usage": "suppliersComponent",
            "title": "A"
        },
        "categories": {
            "type": "Component",
            "usage": "categoriesComponent",
            "title": "A"
        },
        "products": {
            "type": "Component",
            "usage": "productsComponent",
            "title": "A"
        },
  ...
}

Thats correct. Currently, the title of the different targets have to be different. I'll have a deeper look, if we can improve the feature regards to that.

[flovogt]

Hello @grahamrobbo
Thank you for sharing this finding. I've created an internal incident 2080321371. The status of the issue will be updated here in GitHub.
Regards,
Florian

[flovogt]

Supplier Component Supplier Title

Hi @grahamrobbo, I executed the described steps. However, removing the title of the target in the root component does still propagating the title for me. Could you provide us your application code, please? So, we'll have a look on that.

Hi @grahamrobbo, this issue is closed because the second scenario is fixed. The first scenario is not reproducible from our side. If you still face this issue, please open a new issue and provide a link to a snippet.
All the best and thanks a lot for your support,
Florian

[grahamrobbo]

Sorry @flovogt I have been on vacation for a few weeks. I have created a sample and opened new issue #2979