Openui5: Links in Demo Kit don't handle opening in new tabs

Created on 21 Jan 2020  Â·  7Comments  Â·  Source: SAP/openui5

URL (minimal example if possible):

E.g. https://openui5nightly.hana.ondemand.com/api/sap.ui.core.Control

Steps to reproduce the problem:

In the sample page above, click on one of the texts, which looks like a link, with Ctrl / ⌘ pressed.

What happens?

The clicked link, with the explicit command to open it in a new tap, opens in the same page breaking the common web experience.

Any other information? (attach screenshot if possible)

Sometimes, users would like to open links in new tabs in order to stay focused. Other use cases are mentioned in WCAG 2.1 Opening new windows and tabs from a link.

The control sap.m.Link also provides extra information in press event whether the Ctrl key was pressed or not.
https://github.com/SAP/openui5/blob/81879d28babadb91663a39321ae975b0ba45de4d/src/sap.m/src/sap/m/Link.js#L194

It would be nice if Demo Kit could also respect users' choice to open links in new tabs.
Currently, links can be opened in new tabs only via the right click menu.


As I don't own any mouse, would be nice if someone could confirm whether the links can be opened in new tabs with a middle mouse click or not.

bug in progress

All 7 comments

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident 2080055710. The status of the issue will be updated here in GitHub.
Regards,
Diana

Duplicate of #2767 (handled internally in #2080007465)

Hi @codeworrior,

I fail to see how this issue is related to https://github.com/SAP/openui5/issues/2767. There, @whydrae is describing that the page results in 404 if the origin with the # opens the link is in a new tab.
The issue here describes Demo Kit not opening links in new tabs with Ctrl / ⌘ being held down.

Or are those two issues handled in the same ticket?

handled internally in #2080007465

This was my understanding, yes. For me, the complaint is that opening in new tab doesn't work in SDK (sometimes because links are not rewritten properly, sometimes because of the use of the link control).

But as the technical issues behind are two different ones, it might be better to processionals them differently. I'll ask around and re-open the issue if needed.

@boghyon colleagues will handle both problems together in the first ticket (2080007465)

Hello,

I am reopening this issue as we have decided to fix it separately from the other one. We will update it soon with a new ticket ID or BLI.

Regards,
Iliana

Hello @boghyon ,

Thank you for sharing this finding. I've created an internal incident 2080127015. The status of the issue will be updated here in GitHub.

Regards,
Plamen Ivanov

Was this page helpful?
0 / 5 - 0 ratings