Openui5: Demo Kit: Texts in API Reference Are Centered After Viewing Grid Samples

Created on 23 Jul 2018  路  5Comments  路  Source: SAP/openui5

OpenUI5 version:

1.57.0-SNAPSHOT

URL (minimal example if possible):

https://openui5nightly.hana.ondemand.com/#/sample/sap.ui.layout.sample.GridData/preview

Steps to reproduce the problem:

  1. Open the above mentioned sample page of sap.ui.layout.Grid.
  2. Navigate to any API reference e.g. by clicking on API Reference.

What happens?

centered texts

bug fixed

All 5 comments

Hi, @boghyon

Please clear your browser cache and refresh the page.

Best Regards,
Petya

It's not an issue of cache though. Given the steps I mentioned, the behavior is reproducible with any browsers in any sessions.

Of course, if I visit the API reference page directly (refreshing the page), the texts are displayed normally. However, when coming from the mentioned Grid sample, the texts in API reference are all centered as you can see.

The Component.js for the GridData sample defines a CSS include here and I guess it is not cleaned up after the example. The CSS remains active in the SDK and affects all paragraph tags.

First of all, the selector in the CSS has to be made more selective.

But I also wonder why no cleanup is done after the sample. As far as I remember, there's an instance counter in the ComponentMetadata that should remove resources when there are no more instances of a component class.

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident 1870334440. The status of the issue will be updated here in GitHub.

Regards,
Gergana

Hello @boghyon ,

Thanks for reporting this issue. I have fixed the Grid sample with the change and will add another fix later for the Demo Kit to resolve the issue with sample resources not cleaned up.

Thanks again!

Was this page helpful?
0 / 5 - 0 ratings