Opentelemetry-specification: Why are we using such a long name as StatusCanonicalCode?

Created on 6 Oct 2020  路  4Comments  路  Source: open-telemetry/opentelemetry-specification

From https://github.com/open-telemetry/opentelemetry-specification/pull/1067#discussion_r500495896.

Another question is: Are there non-canonical status codes?

api p1 required-for-ga trace

Most helpful comment

I think this should be renamed to just Status (or StatusCategory) after #966. The current enum is not canonical and I also don't know if we want to call it a code.

All 4 comments

I think this should be renamed to just Status (or StatusCategory) after #966. The current enum is not canonical and I also don't know if we want to call it a code.

I don't think this is a blocker for GA but if we intend to change that (and from the 馃憤 on here we seem to have some consensus), we should do so before GA. It should be a simple find-and-replace for SIGs that have already adopted the new Status model and otherwise it would go well along with that change.

I'd prefer to settle this before GA since the names may be part of the API. In that case changing the names will break the API.

from the issue triage mtg today, need a decision on this whether to have it

Was this page helpful?
0 / 5 - 0 ratings