Opentelemetry-specification: Do we really need "branch must be up to date" restriction?

Created on 9 Sep 2020  路  9Comments  路  Source: open-telemetry/opentelemetry-specification

931 is approved, but I, as admin, cannot merge it, nor can I merge master to make it pass this check.

cc @open-telemetry/technical-committee

miscellaneous miscellaneous

Most helpful comment

The reasoning in #512 is

Because we fixed the lint check (broken for 2 months) and started to merge PRs that did not pass the lint check (based on master commit that did not include the fix). This was the only option to enforce that everyone pass the lint check.

I am not convinced it's a good reason, more a reaction to one time issue where bad commits were made due to lack of lint enforcement.

All 9 comments

Duplicate of #512

+1 on this, as it creates too much hassle (but IIRC @bogdandrutu had a reason to enable this).

@yurishkuro I updated the PR in question (I have access to that Dynatrace repository)

The reasoning in #512 is

Because we fixed the lint check (broken for 2 months) and started to merge PRs that did not pass the lint check (based on master commit that did not include the fix). This was the only option to enforce that everyone pass the lint check.

I am not convinced it's a good reason, more a reaction to one time issue where bad commits were made due to lack of lint enforcement.

IMHO fixing the lint with quick follow-up PRs on master is easier than pinging people to update their PRs with organization-owned repos.

Agreed that we should perhaps revert this. @bogdandrutu You ok with that? ;)

From the issue triage mtg today, if @open-telemetry/technical-committee can either execute this requested change or close this issue.

cc @SergeyKanzhelev

I'm ok reverting it. It's easier to fix issue than block PR merges

Was this page helpful?
0 / 5 - 0 ratings