Opentelemetry-js: Request(plugin): mysql

[markwolff]

Is your plugin request related to a problem? Please describe.
Add tracing to mysql query operations

Is it applicable for Node or Browser or both
Node

Do you expect this plugin to be commonly used
Weekly Downloads: ~500k + ~250k

What version of plugin are you interested in using
Node Versions: >=8

[mayurkale22]

mysql and mysql2 (~243K Weekly Downloads) have very closely resembling public APIs, does it makes sense to combine them together ?

[dyladan]

mysql and mysql2 (~243K Weekly Downloads) have very closely resembling public APIs, does it makes sense to combine them together ?

This is what dynatrace does. They actually have the same api. It is a stated goal of mysql2 to be API compatible with mysql

[dyladan]

I am somewhat familiar with the api if you're looking for someone to take this

[markwolff]

I am somewhat familiar with the api if you're looking for someone to take this

Assigned it to you. Let me know if this is an issue :)

[mayurkale22]

Can we close this one via #525?

[dyladan]

@mayurkale22 mysql2 is still not covered. If you close it can you rename it to just request mysql and open a new one?

[mayurkale22]

If you close it can you rename it to just request mysql and open a new one?

@markwolff do you agree with this?

[dyladan]

I attempted to make the mysql one work with mysql2 but the internal implementation details were too different. There will be some shared code, but it wasn't as easy as i'd expected

[mayurkale22]

@mayurkale22 mysql2 is still not covered. If you close it can you rename it to just request mysql and open a new one?

I removed mysql2 from the title, let's close one and handle mysql2 instrumentation based on request.