Opentelemetry-go: Rename SpanContext to SpanReference

Created on 14 Oct 2020  路  4Comments  路  Source: open-telemetry/opentelemetry-go

Update needed to track these changes: https://github.com/open-telemetry/opentelemetry-specification/pull/1075#

trace help wanted API p1 required-for-ga
Source
picture MrAlias

Most helpful comment

@MrAlias Mind if I take this one?

picture cpackingham on 15 Oct 2020
👍2

All 4 comments

@MrAlias Mind if I take this one?

cpackingham picture cpackingham on 15 Oct 2020
👍2

Definitely going to need some extra eyes on the opentracing bridge and the exporters. Opentracing seems to have its own concepts of SpanReference and SpanContext so renaming is pretty dicey there - same with Zipkin. There are also Golang contexts.

cpackingham picture cpackingham on 20 Oct 2020

@MrAlias This issue should be closed - the decision to rename SpanContext was reverted in the spec: https://github.com/open-telemetry/opentelemetry-specification/issues/1126

cpackingham picture cpackingham on 27 Oct 2020

@cpackingham thank you for digging into this and sorry it ultimately was wasted time. :disappointed:

MrAlias picture MrAlias on 27 Oct 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

johananl picture johananl  路  6Comments
paivagustavo picture paivagustavo  路  8Comments
MrAlias picture MrAlias  路  6Comments
MrAlias picture MrAlias  路  6Comments
ThomsonTan picture ThomsonTan  路  3Comments