Opentelemetry-go: Suggestion: rename `CurrentSpan`/`SetCurrentSpan`

[iredelmeier]

Thoughts on renaming these to SpanFromContext and ContextWithSpan to be more idiomatic?

[VineethReddy02]

Hey, @iredelmeier I would like to work on this. Could you help me what are exact changes required?
Could you please point me some good first issues in getting started to contribute to open-telemetry.

[iredelmeier]

@VineethReddy02 the change for this should basically be a find-and-replace for the function provided in current.go (which should probably also be renamed!) and their usages.

With the caveat that a PR implementing this suggestion may get rejected on the basis of the suggestion itself getting rejected, this would definitely be a good first issue! Inconveniently, I'm unable to modify issue labels in this repo.

Some more good first issues (definitely non-exhaustive!):

• #181
• #184 (blocked on some decision-making)
• #186 (possibly)
• #192
• #195

[rakyll]

See also https://github.com/open-telemetry/opentelemetry-go/issues/299.

[iredelmeier]

@VineethReddy02 are you still able to work on this?

[VineethReddy02]

Hey @iredelmeier so what CurrentSpan & SetCurrentSpan should be renamed to?

[iredelmeier]

@VineethReddy02 CurrentSpan -> SpanFromContext and SetCurrentSpan -> ContextWithSpan

[jmacd]

@rakyll proposed "WithSpan" as opposed to "ContextWithSpan". What do you think? I do feel that "Context" adds stutter here. If we went with "WithSpan", what's the opposite name? (I still like CurrentSpan). Also if we went with "WithSpan", there's a Tracer.WithSpan, similar to trace.WithRegion in the builtin library, that creates confusion.

[paivagustavo]

I like more trace.ContextWithSpan (it is a little verbose but more clear than trace.WithSpan that could be misleading) and trace.CurrentSpan.

[jmacd]

Although the PR merged, I am open to renaming trace.SpanFromContext to trace.CurrentSpan.

[rghetia]

stale issue.