Opentelemetry-dotnet: Replace AddTag with SetTag

Created on 3 Sep 2020  路  3Comments  路  Source: open-telemetry/opentelemetry-dotnet

SetTag seems to be the way to go and we probably want to replace all AddTag calls in this repo?

https://github.com/open-telemetry/opentelemetry-dotnet/search?q=AddTag&unscoped_q=AddTag

bug
Source
picture reyang

All 3 comments

@reyang , are u going to replace? or should I?

eddynaka picture eddynaka on 3 Sep 2020

Feel free to take it.

reyang picture reyang on 3 Sep 2020
👍1

@eddynaka Also check if we are retrieving Activity.Tags. It should be Activity.TagObjects

cijothomas picture cijothomas on 3 Sep 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

mbakalov picture mbakalov  路  3Comments
JamesNK picture JamesNK  路  5Comments
reyang picture reyang  路  5Comments
cijothomas picture cijothomas  路  5Comments
cijothomas picture cijothomas  路  4Comments