Openstreetmap-website: When a user posts a story in their diary, give them the option to share with social media

Created on 14 Dec 2016  路  10Comments  路  Source: openstreetmap/openstreetmap-website

Give them the option to share with Twitter, Facebook, Instagram, Jabber (XMPP) etc.

All 10 comments

Hello can I work on this?

It's open source, so you can work on any issues you want to. This one is probably a reasonably good starter issue because it's a small front-end change, and it's unlikely anyone else is working on it.

I wouldn't say it was small myself. I mean it won't need that much code but it will presumably mean dragging in some third party component(s) and hence making a choice about which is best to use. There will also be significant privacy issues to deal with.

By all means do have a go at it - nobody else is as far as I know - but I wouldn't say it's trivial.

I don't see significant privacy issues, maybe we're imagining different implementations? For the twitter case it'd be a link like https://twitter.com/intent/tweet?original_referer=http%3A%2F%2Fpaulnorman.ca%2Fblog%2F2016%2F11%2Fserving-vector-tiles%2F&ref_src=twsrc%5Etfw&text=Serving%20Vector%20Tiles%20-%20Paul%E2%80%99s%20Blog&tw_p=tweetbutton&url=http%3A%2F%2Fwww.paulnorman.ca%2Fblog%2F2016%2F11%2Fserving-vector-tiles%2F

e.g.
image

There probably is some third-party component that URL formation for common social media networks

Well that's the ultra low tech approach for twitter sure, but I think a more normal approach would be to use one of the gems I'm sure exists that adds some sort of sharing panel for a range of sites - the important thing would be to ensure that it didn't load anything from the sites until you chose to use it.

Hey @tomhughes and @pnorman I tried running bundle exec rake db:migrate and I ran into this error. How would I fix this?

Hamels-MacBook-Air:openstreetmap-website HD$ bundle exec rake db:migrate
svgo worker: `svgo` not found; please provide proper binary or disable this worker (--no-svg
o argument or `:svgo => false` through options)

-Thank you.

That's just a warning that can be ignored - I'll figure out how to get rid of it at some point!

Hey @tomhughes, @pnorman, @gravitystorm I added the gem gem social-share-button, but in the gem's documentation it requires me to add *= require social-share-button to the application.scss file.

I do not see that file in the stylesheets folder. I was wondering should I create that file or should I place the content (*= require social-share-button) somewhere else within the stylesheets folder.

  • Thank you.

Probably best to put it in screen-ltr.css and screen-rtl.css although you might want to consider only loading it on those pages that need it rather than loading it site wide.

Hello @tomhughes, @pnorman, @gravitystorm I added the social media icons to diaries. Let me know what you guys think if I should make any changes.

-Thank you.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jidanni picture jidanni  路  3Comments

kgreenek picture kgreenek  路  6Comments

grischard picture grischard  路  3Comments

HarelM picture HarelM  路  7Comments

HolgerJeromin picture HolgerJeromin  路  5Comments