Opensourcepos: Error in syntax for 2.3_to_2.3.1.sql

Created on 16 Aug 2017 · 4Comments · Source: opensourcepos/opensourcepos

Issue / Question / Bug

Before submitting an issue please make sure you tick (add an x between the square brackets with no spaces) the following check boxes:

[x] I'm reporting an issue of an unmodified OSPOS installation
[x] I checked open and closed issues database and no similar issue was already discussed (please make sure you searched!)
[x] I read the README, WHATS_NEW and UPGRADE
[x] I read the FAQ (https://github.com/jekkos/opensourcepos#faq) for any known install and/or upgrade gotchas (in specific PHP has php-gd, php-intl, sockets and etc. installed)
[x] I read the wiki
[x] I ran any database upgrade scripts (e.g. database/2.4_to_3.0.sql), and migrating function
[x] I'm aware the latest master could be a development version and therefore not stable
[x] I know the version of OSPOS and git commit hash (check the footer of your OSPOS), the name and version of OS, Web server, PHP and MySQL and will add them to my issue report

Installation information

OSPOS version is: Migrating 2.0.2 to 3.1.0
OSPOS git commit hash is: unknown
PHP version is: (e.g. 5.5, 5.6, 7.0, 7.1) 5.6.31
MySQL or MariaDB version is: (e.g. MySQL 5.5, MySQL 5.6, MySQL 5.7, MariaDB 10.0, MariaDB 10.1, MariaDB 10.2) MySQL 5.7
OS and version is: (e.g. CentOS 6.9, Ubuntu 16.4, Windows 10) FreeBSD 11
WebServer is: (e.g. Apache 2.2, Apache 2.4, Nginx 1.12, Nginx 1.13) Apache 2.4
(If applicable) Installation package for the LAMP/LEMP stack is: (e.g. WAMP, XAMPP) FAMP

Expected behaviour

Line 84 of /database/2.3_to_2.3.1.sql should read ('sales_invoice_format', '$CO');

Actual behaviour

Line 84 of /database/2.3_to_2.3.1.sql currently reads ('sales_invoice_format', '$CO'),
The comma instead of semicolon at the end of the line causes MySQL to fail because it's expecting something else after the comma and that is supposed to be the end of the query.