Opensourcepos: Dinner Table feature in Sale module

[deepshah]

New Feature or Enhacement

I am building a feature to select tables in the sales module. When a sale is started, the employee can select a table where the order has come from. No new sale can be added to a table which is already being served (the sale is suspended). Also, there will be two special tables- delivery and take away. Feature is almost built.

[deepshah]

I would also like to know is there a way to automatically generate the required translations for a new word (in this case 'Table') and add it to the translations files?

[daN4cat]

Thanks for the contribution proposal, when you say table I assume you mean restaurant table (physical one). We are so used to talk of tables as data representation that it's easy to mess up.

It would be nice to have that view and controller as addition to OSPOS for horeca type of business.

[deepshah]

Sorry about the confusion. Yes, I do mean the restaurant table (I have named it dinner_table). I faced the same issue when naming the database table for it.

[odiea]

The database.sql gives errors when installing but using ospos database.sql then 3.0 to 3.1 it worked ok. I see it takes the place of the standard stock location in the register. This appears to be an issue. Like you said needs to be a config item.

[deepshah]

Hi @odiea
I have fixed the errors. I did not understand the part about dinner table taking place of stock location in the register. Could you ellaborate it?

[odiea]

The first image is from standard OSPOS. Includes stock locations.

The second image is from your version. Stock location is gone but your Table location is shown in it's place.

[deepshah]

The option of stock location is shown only when there are more than 1 stock locations. (This is the case in the current master itself)

[odiea]

Sorry I stand corrected. Stock locations appear just fine.

[odiea]

The other minor issue would be after I unsuspend a table the Table number is set to the first table in the drop down list and not the original table .

[deepshah]

Have fixed this.

[daN4cat]

Is this rebased with the latest code?

[odiea]

After merging it into the Master I tested this some more.
There is no way to disable it that I have found.
After you delete all the tables there is no longer a place holder to Install new tables.
Other feature on Register works nicely.
This may be petty but is there a way to put another drop down for the employee id so they can be credited for their Sales.

[daN4cat]

Either @deepshah or @jlctmaster need to take this and bring to a conclusion as it's not completed as it stands.

[jlctmaster]

Hello, I'm working on a new branch, when I have something ready to upload it I'll do the PR

[deepshah]

Hey guys, sorry for replying so late. I have been busy with some other stuff and not been able to work on this. @jlctmaster feel free to take off from where I left it.

[daN4cat]

@odiea @jlctmaster this looks completed, correct?

[odiea]

So far it appears to be working ok. I don't see changes in Reports to see why the table number was added to the Sales table. I do see changes at the Register and Store config.

[jlctmaster]

Hi, for that I am thinking of making a module in the menu where you can take the orders and automatically save them as a suspended sale and that is registered which was the innkeeper that attended the client at table X, and that is the innkeeper who confirms the Sale, so that it can be invoiced in cash, this is where you can see in the sales module as a suspended sale for your billing.

[SteveIreland]

For the record, the sales tax changes required a new module too - and I'm using the paper currency icon for it. I recall that the pencil symbol is available.

[jlctmaster]

For this module I can design an image that represents the symbol of the restaurant as the one in the attachment.

[SteveIreland]

Looks great.

[daN4cat]

Nah.. we need to be consistent with the design. There is already a big set of icons stored in a dir, please choose one that gives the idea.

[jekkos]

Just had a look at the SQL script to upgrade for this feature. I wonder why we keep duplicating sales tables, maybe adding suspended as a simple boolean column will suffice to check if table is suspended or not.

[daN4cat]

@jlctmaster I tested the latest master and if I didn't enable the tables and then I go to unsuspended I get an error:

A PHP Error was encountered

Severity: Notice

Message: Trying to get property of non-object

Filename: models/Dinner_table.php

Line Number: 63

please check.

[daN4cat]

Checking the suspended table the dinner_table_id is NULL.
Not sure that as relevance here, I just want to add more info that could be useful.

[jlctmaster]

Hello, that's right, the dinner_table attribute in the sales_suspensed table must be NULL since if NOT NULL is applied, the list of tables must be shown in the billing and this prevents it from being configurable.

[SteveIreland]

I'm dropping the set of suspended tables as part of the sales tax feature, so should I assume that the same rule would apply for the dinner_table_id in the sales table? .... for suspended sales?

One thing I did change related to the dinner table feature is that I changed the list of suspended sales to not include the dinner table column if the dinner table feature was not enabled.

[daN4cat]

@jlctmaster ok but there is the error that I reported above please test and fix:

A PHP Error was encountered

Severity: Notice

Message: Trying to get property of non-object

Filename: models/Dinner_table.php

Line Number: 63

[daN4cat]

@SteveIreland yes if suspended is changed even dinner tables should follow. @jlctmaster please follow up on that.

[daN4cat]

@jlctmaster fixing this, I also spotted that in Suspended Table column is added even if disabled in Store Config. So fixing that too.

[daN4cat]

@SteveIreland if you drop the suspended tables could you please include the change to Dinner Table? It's better to make one change for all in one place as that simplifies the matter.

[SteveIreland]

Already done sir. Thanks.

[damianzoanni]

can we use this module to hotels/hostal rooms?

[daN4cat]

@damianzoanni and what would be the specific requirement for the case?
Dinner Table is a means to identify a table in a place, if you mean that you want to identify the room instead of a table it's probably just a matter of "translation". But I'm guessing a bit here.

[damianzoanni]

@daN4cat it well be nice if this module can be cloned for Hotels.. or for reception to repair celular phone... or other .. maybe with some abstraction of the name of module we can make many instances of the module and make it configurable

[daN4cat]

@jlctmaster food for thoughts....

[jlctmaster]

Good idea, it would be nice to be able to expand that functionality to apply it to other similar scenarios.

[daN4cat]

@jlctmaster so you need to make it generic and not a Dinner Table type of functionality.
It's something that has to do with location.

[jlctmaster]

Of course, there are things that are exclusive to a process, but others such as what mentions @damianzoanni to use the module for a hotel or a repair shop of cell phones, this could be integrated with the current module with the minimum of modifications.

[daN4cat]

@jlctmaster I leave to you the fun. I don't need this. I just fixed the issues I spotted to keep things working smoothly and generic when the module is not enabled.

I assume that you may want to title things to be "Dinner Table", "Hotel Room", "XYZ" with the drop down options you want.
In that way you make it quite generic.

Of course database table needs to be renamed...

[damianzoanni]

let's make it real

[daN4cat]

@jlctmaster I just want to understand if you plan to or are working on making this feature more generic as I want to understand what's left to close 3.1.0.

[jlctmaster]

Hello @daN4cat , I'm still not working on this, there are certain things that should be better defined to give you the support you want, you can close the support in this version 3.1.0

Greetings.

[kandesmond]

Hello there,

I have replaced the application/models/Dinner_table.php and application/views/sales/suspended.php with the newer codes that were dated on March 13 and I am still having the table issues. Could anyone here help?

Thanks for your help in advance.
-Desmond

[odiea]

Download the latest version and do the database updates or create a new database.

[kandesmond]

I think I am using the latest version - 3.1.0 - 4f5ad57. Please let me know IF this is not the latest version. I will give it a try to drop and re-create the new database.

Thanks for your prompt response.

[odiea]

You should download todays current 3.1.0. This is still a Beta with additions being added or changed weekly.

[kandesmond]

ok. I have downloaded the latest version (the time stamp on the codes are May 24th) and reload everything from scratch, dropped and re-created the database and I am still having the suspended table issues. Please help !!!

Thanks,
-d

[odiea]

What is the issue. Is it the Table number still shows in the dropdown list after a table has been suspended or other issue. Would someone please look into the table suspend feature not working properly.

[kandesmond]

The issue is ... the table name doesn't stick to the original one every time I UN-suspeneded it. It got reset it back to the first table in the drop down. Below is the sample.

Table name

Delivery
Take way
Table 1
Table 2
Table 3

I suspended a sale for table 2 and the sale will get reset it back to "Delivery" every time I UN-suspended it.

Thanks for looking into this.

-Desmond

[kandesmond]

Hello there,

Any luck on the fix?

Thanks,
Desmond

[daN4cat]

@jlctmaster can you please look into this issue?

[odiea]

The following link will get you the original dinner table feature minus anything that has been added since this commit. It appears to be working https://github.com/jekkos/opensourcepos/tree/6826115b2d029f6282e4fc2d7469b7576b0b436d

[kandesmond]

got it. so this build (the timestamp on this build is Feb 26. So I guess the changes in this build was not merged into the latest build?

Thanks for the link. I will give this build later tonight.

I will keep you guys posted.

[odiea]

The latest does contain this feature but was broken after other new code was added.

[kandesmond]

Got it. Good to know. Also, Is it possible to have a "floor plan" with all the tables in system? if not, will this feature be added or is it already on the roadmap somewhere? if no, can this feature be requested?

Thanks,
Desmond

[odiea]

If you want to use the Customer Rewards feature the following link is also working. Currently I believe most requests are on hold unless some User is willing to add that feature.
https://github.com/jekkos/opensourcepos/tree/cdc401dd7e1ad0827f96f511a65671d19c819c2a

[odiea]

View issue #1196. Another requested feature.

[daN4cat]

The table part really needs a dedicated owner otherwise I see it hard to progress. Neither I nor @jekkos have any driving reason to work on this as not a retail use case.

[kandesmond]

ok. Thanks for the heads up on the feature request.
Also, do you have any ETA when the latest build will have the fix for the suspended table issues.
I don't want to go back to the older build if the fix is coming soon ?

Thanks for your understanding.

P.S. I really like to stay with OSPOS because OSPOS is the best out of all the POS systems that I have tried so far.

-Desmond

[daN4cat]

I hope @jlctmaster can help here and fix the issue. I don't have that much time to dedicate to this project at the moment.

[kandesmond]

dan4ca,

Thanks.

jlcaster,

Please help !!!
:)

Thanks for all of your help as always.
I am really appreciated all of your help.
-Desmond

[jlctmaster]

Hi, sorry for the absence, I have been short of time by a project that I am currently working on, I understand that the error they report is when the suspended sale is restored, it is not tied to the original table with which the order was made, if not with the default being "Delivered."

This is so it?

[odiea]

That and the suspended table still shows in the dropdown list of available tables.

[kandesmond]

Jlcmaster,

Yes. That's correct.

Please help.

Thanks for your help in advance.

Cheers
-d

[odiea]

It appears that the issue is the way suspended sales are now being kept in the database. When I suspend sales in a working version of Dinner Tables and then go to the newer version it functions properly until the suspended sales are all unsuspended.

[daN4cat]

@odiea do you have time to understand when this suspended feature was touched?

[odiea]

That's what I have been trying to find out. I believe it was introduced with @SteveIreland new Tax feature. I did a work around in Controller/Sales.php that if Dinner tables was used it would revert back to the old suspended tables. I will include it for your inspection.
~~~
public function suspend()
{
$dinner_table = $this->sale_lib->get_dinner_table();
$cart = $this->sale_lib->get_cart();
$payments = $this->sale_lib->get_payments();
$employee_id = $this->Employee->get_logged_in_employee_info()->person_id;
$customer_id = $this->sale_lib->get_customer();
$customer_info = $this->Customer->get_info($customer_id);
$invoice_number = $this->_is_custom_invoice_number($customer_info) ? $this->sale_lib->get_invoice_number() : NULL;
$quote_number = $this->sale_lib->get_quote_number();
$comment = $this->sale_lib->get_comment();
if($this->config->item('dinner_table_enable') == FALSE)
{
$sale_status = '1';

    $data = array();
    $sales_taxes = array();
    if($this->Sale->save($sale_status, $cart, $customer_id, $employee_id, $comment, $invoice_number, $quote_number, $payments, $dinner_table, $sales_taxes) == '-1')
    {
        $data['error'] = $this->lang->line('sales_unsuccessfully_suspended_sale');
    }
    else
    {
        $data['success'] = $this->lang->line('sales_successfully_suspended_sale');
    }
    }
    else
    {
        //SAVE sale to database
    $data = array();
    if ($this->Sale_suspended->save($cart, $customer_id, $employee_id, $comment, $invoice_number, $quote_number, $payments, $dinner_table) == '-1')
    {
        $data['error'] = $this->lang->line('sales_unsuccessfully_suspended_sale');
    }
    else
    {
        $data['success'] = $this->lang->line('sales_successfully_suspended_sale');
    }
    }

    $this->sale_lib->clear_all();
    $this->_reload($data);
}

~~~

[odiea]

It is part of the 3.0.2_to_3.1.0.sql database.
ALTER TABLE ospos_sales
ADD COLUMN quote_number varchar(32) DEFAULT NULL,
ADD COLUMN sale_status tinyint(2) NOT NULL DEFAULT 0;
The Sale Status is where it appears suspended sales are now being tracked.

[odiea]

This link shows when it first appeared.
https://github.com/jekkos/opensourcepos/search?utf8=%E2%9C%93&q=sale_status+&type=

[SteveIreland]

Just to add my 2 cents (about what it's worth). The design intent was to ultimately drop the old suspended tables so that we no longer have to deal with both. I'd hate to have been responsible for creating a situation where suspended sales are kept in both sets of tables.

The only reason I didn't drop them immediately was because of the existing data in the suspended sales tables. At that time I wasn't sure what the migration rules were and I thought it would be acceptable to have a built in migration as old suspended data was "unsuspended". Of course now that I've had to set up migration for sales tax history the obvious solution would have been to create a migration for suspended sales tables and remove them.

[odiea]

The issue is can you get the dinner table feature to work with your newer suspended feature because it does not work properly now.

[SteveIreland]

I'll start getting up to speed on the Dinner table issue. I'm sure it won't be wasted time since it's always been a fantasy of mine to open up a pop up Tex-Mex restaurant. :smile:

[kandesmond]

Steve,

Thanks for working hard on this.

I am really appreciated it.

-d

[daN4cat]

There is a problem with the config, when the submit is clicked there is no pop up notification confirming all is fine. @SteveIreland, when fixing this could you please check into that issue as well?

[daN4cat]

Also the behaviour of the input boxes is not correct when the checkbox is unticked and submit is clicked. They should stay grey/disabled.

[odiea]

@daN4cat I cannot duplicate the config issues. Both appear to be working correctly .

[daN4cat]

Strange I can see:

A PHP Error was encountered

Severity: Notice

Message: Undefined variable: Delivery

Filename: models/Dinner_table.php

Line Number: 14

[daN4cat]

I wouldn't that it's a PHP version related issue. Which version do you use? I have 5.6

[odiea]

7 something.

[daN4cat]

I found the root cause. Quick testing and I should be ready to submit. It's probably due to the PHP version.

[odiea]

I will try it in 5.6 and see what it does.

[odiea]

PHP Version 5.6.15 I tried it on this version with a new db and I have no issues.

[odiea]

The Dinner Tables feature is still not working in Sales with a new db but the config looks ok on my end.

[daN4cat]

Fixed the Config tables notification pop up issue.

[SteveIreland]

I'll rebase again on the latest master and give my changes some more testing. It does include the fix for the unsuspending dinner table issue.

[SteveIreland]

Testing and debugging is going pretty well. However, I want to focus on VAT tax testing tomorrow night.

And I just wanted to add that I tested the config changes and they are working fine on 7.0.10 of PHP and 5.7.14 of MySQL for me. Thanks.

[daN4cat]

Config for tables it's fine since I fixed it.

[kandesmond]

Thanks everyone.

Is there a way to get the fix for the suspended tables issues?
Thanks

-d

[daN4cat]

@kandesmond it's ongoing, @SteveIreland is testing his fix.

[kandesmond]

Got it. Thanks.

[jlctmaster]

Hello everyone, I have been able to review the recent changes and I have applied the correction to the error presented with the feature of the dinner table, please check the PR.

[SteveIreland]

I assume that means I'll need to rebase again and resolve conflicts. But that's cool. I'm becoming an expert at rebasing.

[jlctmaster]

You were working on solving this bug? I'm sorry.

[daN4cat]

I merged the fix, @kandesmond please test and confirm it's fixed. Same for @odiea and @SteveIreland if you find the time.

[daN4cat]

Thanks @jlctmaster for the help

[jlctmaster]

No problem sorry for the delay

[kandesmond]

I will definitely try it out later tonight.

Thanks everyone.

[odiea]

Appears back to being functional again. Drop down does not show suspended tables and when unsuspended the table name or number is retained. Good Work.

[kandesmond]

it's fixed and it's working great now.

Thanks for fixing it.

Cheers
-d

[kandesmond]

I found one minor issue and I don't think it's a big major issue but I figure out that I should point it out.

below is my settings.

Table name

Delivery 1
Take away 1
Delivery 2
Take away 2
Table 1
Table 2
....
Table 10

I suspended a sale for "Delivery 1" and it got suspended and un-suspended without any issues but "Delivery 1" is still available in the drop down for the new sales.

It's only happening to "Delivery 1" though. The rest of table features are still working great.

Thanks,
Desmond

[daN4cat]

@jlctmaster can you please check the new issue and fix?

[kandesmond]

Sorry, one more. i just tested it ... it's also happening to Take away 1.

I have tested it all the way to Table 6 and it's fine.

so it seems it's only happening to the first Two tables in the drop down.

[jlctmaster]

Hello, this is not an error but the basic functionality of this feature, since according to the logic with which this functionality was tested is the following, the records that come preloaded "delivery" and "take away" should not be reserved in the sale, if it is true that at the moment of suspending the sale this keeps the selected record, however, these should always be available.

With the rest of the records are supposed to be tables where the customer goes to the restaurant is lodged at a table, makes his request and at the time of retirement asks the account.

This is how it is programmed this characteristic, it is also interesting to know when it would have more than one concept that indicates that it is "delivery" or "take away"

[kandesmond]

jlcmaster,

Got it. Thanks for your answers.

-d