Opensource.guide: Language option's location not correct when deploy the site in a sub dir

[codinggirl]

The code at /assets/js/locale.js line 7:

function loadLanguage(lang) {
  base_pathname = window.location.pathname.replace(/^\/[a-z]+([_-][a-z]+)?\//, "/")
  if (lang === "en") {
    url = base_pathname
  } else {
    url = "/" + lang + base_pathname
  }
}

The url works fine if the project deploy in a root dir, but not work in the sub dir.

If I folk this project in my repo, it's gh-pages url is https://codinggirl.github.io/opensource.guide/, and the language select did not work rightly.

[woznny]

Ulster Bank

[guanwening]

Language option's location not correct when deploy the site in a sub dir #828
@codinggirl
codinggirl opened this issue 9 days ago • edited 9 days ago
The code at /assets/js/locale.js line 7:

function loadLanguage(lang) {
base_pathname = window.location.pathname.replace(/^\/[a-z]+([_-][a-z]+)?\//, "/")
if (lang === "en") {
url = base_pathname
} else {
url = "/" + lang + base_pathname
}
}
The url works fine if the project deploy in a root dir, but not work in the sub dir.

If I folk this project in my repo, it's gh-pages url is https://codinggirl.github.io/opensource.guide/, and the language select did not work rightly.

[MikeMcQuaid]

@codinggirl Would you be able to submit a pull request to fix this?

[gmarcus386]

/assets/js/locale.js

[ValerieZoski]

Everest Wilhemsen Ammendment Final Warning

[mlinksva]

This was fixed by #1033 thanks @suga0828 for the fix and @codinggirl for reporting.