Openshot-qt: Split Clip: Off by a frame

[peanutbutterandcrackers]

OpenShot v2.4.1-dev1 (daily build: Mar 12 2018)

In light of #1365, I think what I experienced yesterday is, indeed, a bug that needs fixing.

If one uses the 'split clip' dialogue to split the clip and set a 'start' and an 'end', and drag the clip on to the timeline, I can see that the frame before the one I set as 'start' is the first frame and the frame before the frame I set as the 'end' is the end frame.

What I think is happening is that OpenShot uses 1-based-indexing for frames. However, Python (and perhaps C++ too) use 0-based indexing. So, basically, I think merely adding '+1' somewhere (or in multiple places in the code) should fix it. Definitely.

[DylanC]

@peanutbutterandcrackers - You could be right here! Sounds like it makes sense.

[DylanC]

@peanutbutterandcrackers - Is this bug still here in v2.4.2?

[peanutbutterandcrackers]

@DylanC - Yes, sir! Still there. It's still starting one frame before the 'start' point and ending one frame before 'end'. At one point, the end seemed to work too but I must have been mistaken. The splitter needs some more work.

[stale[bot]]

Thank you so much for submitting an issue to help improve OpenShot Video Editor. We are sorry about this, but this particular issue has gone unnoticed for quite some time. To help keep the OpenShot GitHub Issue Tracker organized and focused, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.
This issue will be closed, as it meets the following criteria: - No activity in the past 180 days - No one is assigned to this issue
We'd like to ask you to help us out and determine whether this issue should be reopened. - If this issue is reporting a bug, please can you attempt to reproduce on the latest daily build to help us to understand whether the bug still needs our attention. - If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.
Thanks again for your help!