Openscope: Comma in between commands is not accepted

Created on 28 Nov 2018  路  4Comments  路  Source: openscope/openscope

Commas placed in between commands should be accepted (they currently are not)

Example:
"[callsign] caf, to" responds with say again
it should be equivalent to "[callsign] caf to"

discussion

Most helpful comment

That is very much on purpose, commas are not allowed as part of a command string. I'm not sure why you would want them? If you can make the case, we can certainly discuss it, but this is currently working as designed.

All 4 comments

That is very much on purpose, commas are not allowed as part of a command string. I'm not sure why you would want them? If you can make the case, we can certainly discuss it, but this is currently working as designed.

I frequently accidentally put commas inbetween commands and it doesn't make much sense for them to not be allowed.

our rationale is that is an extra keystroke and doesn't make sense to include them.

our command parser is built to look for only valid commands, if it sees anything along the way that it's not expecting, it will reject the command (or commands). the comma, as you've discovered, is considered an invalid command.

@openscope/simulator-collaborators feel free to chime in if you guys feel differently.

Hi @blane1257! I agree with @n8rzz-- truth be told, it does sound simple enough to say that a comma shouldn't wreck the whole command, but the reality is that it is already a very complicated system that allows us to chain multiple commands together like this: a 150 x t r 250 - 290. The simple fact of the matter is that, at this stage, it would not be worth the moderate addition of complexity in the logic to get it to successfully ignore commas. The most likely result of that change would just be more and more bugs, so I can't see a good reason to move in that direction.

Nonetheless, we appreciate the input. Often times these ideas take us to good places, but this change in particular is not one we ought to pursue.

Closing.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sam-irl picture sam-irl  路  3Comments

tdawe picture tdawe  路  3Comments

cake-pie picture cake-pie  路  6Comments

erikquinn picture erikquinn  路  6Comments

erikquinn picture erikquinn  路  4Comments