Openrefine: Numeric Facets not working on 2.6

[ultraklon]

Choose a numeric column, select numeric facets, the automatic facet draw should be shown, instead the message "No numeric value present." is shown there.
In 2.5 this is working ok

[magdmartin]

I just test it with openrefine-2.6-beta.1 (linux) and the numeric facet
works fine. The beta version has been tested by the community and such
bug should have been caught earlier in the process.

Can you double check that you are dealing with numeric value (they
should be in green on your screen).

If so can you provide more information regarding the distribution you
are using (beta or alpha release with your operating system)

Thanks for your help.

On 13-12-29 06:44 AM, Pablo Moyano wrote:

Choose a numeric column, select numeric facets, the automatic facet
draw should be shown, instead the message "No numeric value present."
is shown there.
In 2.5 this is working ok

—
Reply to this email directly or view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/841.

[tfmorris]

Pablo & Martin - Thanks for testing.

Pablo - could you clarify whether you tested 2.6 beta 1 or the current development head?

I need to double check, but one possibility is that I may have unintentionally pushed a jQuery upgrade to Github before it was ready. That could explain issues like this.

[ultraklon]

@magdmartin sorry, I as told before, I'll start to be more specific, I really want to be helpful

@tfmorris I'm testing this in development HEAD. As you mention, the jQuery version may be affecting the project, you can check this pull request as an example
https://github.com/OpenRefine/OpenRefine/pull/840
but in this case I've been investigating and one clue could be that if you go to the file ExpressionBasedRowEvaluable.java and after line

ExpressionUtils.bind(bindings, row, rowIndex, _columnName, cell);

you add something like this

System.out.println("is Number: " + (_eval.evaluate(bindings) instanceof Number));

you'll have false instead of true

I'm testing all this with the data set given here
https://code.google.com/p/google-refine/issues/detail?id=400
with that same steps and it fails when creating a new facet

Maybe I'm lost because I don't know the code that much, but I think that the number values may be evaluated as String instead of Number or something like it

[tfmorris]

@ultraklon Did you ever get any more information on this?

All - I haven't seen this, but we should explicitly test it for the 2.6 release.

[magdmartin]

tested again in OpenRefine 2.6 RC1 on a linux machine. The numeric facet works fine.

[jackyq2015]

I believe that you missed the step "Edit the Cell"-->"Common Transform"-->"To Number". The idea that the engine dose not aware of the numeric type unless you tell it so. Suggest to close if there is no further information to indicate otherwise.

[JosefAssad]

Ah, it might be something local, and it might also be me doing something obviously wrong, but I can reproduce this. Openrefine 2.7 on Debian stable, reproducing my dataset at the bottom of this comment.

Steps to reproduce:

1. Import the dataset
2. Transform the "rooms" column to number
3. Add numeric facet on Rooms column
4. Observe how histogram looks correct
5. Click "change" on the facet
6. Enter value>2 as GREL
7. Observe that the preview assigns the right booleans
8. Click ok on the facet expression modal box
9. Observe: dataset has not been filtered, the facet box says "No numeric value present"

Dataset:

Description,Rooms,Price
Hello world,1,1000000
Foo,2,2000000
Bar,2,500000
Baz,3,3400000
Qux,2,2100000
Walter,5,760000
Rhonda,1,23000
Mickey Mouse,4,450000

[ostephens]

I think this is the expected behaviour. A 'Numeric Facet' can only represent numeric outcomes - but by changing the facet expression to value>2 you have a boolean outcome. For this to work, you need to use the 'Custom Text Facet' (or do a text facet and click 'change' and enter the expression)