Openrct2: Maze height is higher than it should be

[Derpercoaster]

OS: Windows 10
Version: 0.2.6
Build: I do not know.

Issue: The height of the hedge maze is a bit higher than it should be, which prevents other objects from being placed above it at the correct height.

To reproduce:

Simply build a maze, and try to make a path over it, 2 units higher than the maze itself (You can also build a prebuilt maze with paths going over it at 2 units higher than the maze itself.).

[Gymnasiast]

Guests sometimes jump up to peek over hedges. Building directly on top of the maze will just cause them to bump their heads.

[RFoxtea]

The "Crazy Castle" ride design that is shipped with the game includes elements that are placed 2 units above the base level of the attraction. Without enabling the "disable clearance checks" cheat it doesn't load in completely, lacking some vital path pieces.

Guests don't bump their heads at this height.

[Gymnasiast]

Right, so the clearance height is higher than 3 metres? That would indeed be a bug.

[Derpercoaster]

I would expect something in the original game files to be unaffected by in-game parameters (in such a way that it does not work properly). I knew it wasn't right.

[Gymnasiast]

Track element height is saved in the executable, not in the object files.

[C-Fergus]

The "Crazy Castle" ride design missing some queue pieces is reproducible on:

OS: Linux Mint 19.3 Cinnamon (Ubuntu 18.04)
Version: v0.2.6
Build: 6c3c857df on HEAD

Upon testing, the minimum height above the level of the maze where building can occur is 4 metres. Is the height + 2 on each of the maze objects in /src/openrct2/ride/gentle/Maze.cpp (link here) the height of the maze piece or the clearance above it? If it is the height then I don't see why it needs to be 2 as each maze piece is only 1 metre high, and the clearance probably does not need to be 2 metres above that. I imagine in RCT2 the height of the maze would be 1 metre and the clearance would be 1 metre above that for the "Crazy Castle" design to work.

Either way, I think reducing the z offset bounding box would by 1 metre would fix the issue but I don't have a C++ environment to test, I'll have a look at the weekend if no one fixes it by then.

[Gymnasiast]

Currently bisecting. The issue is not present in v0.2.0, but already present in v0.2.5.

[Gymnasiast]

Bug was introduced by 783ae13538f016cd99b8e49b8563865af9772d5c.

Ironically, the commit message read This game action had been accidently assumed to be hard to do. Woops..

[C-Fergus]

Well found, odd that it was programmed with a specific clearance height constant for the maze as though the clearance height would be different for each ride. Would have thought the clearance height would be constant across all rides.

[Gymnasiast]

The game action used is specific to mazes, so we _know_ what the clearance height is. It indeed differs between ride types.