Openrct2: Remove an unnecessary null pointer check

Created on 25 Jul 2018  ·  3Comments  ·  Source: OpenRCT2/OpenRCT2

An extra null pointer check is not needed in a function like “NetworkConnection::SetLastDisconnectReason”.

picture elfring

Most helpful comment

The idea of open source is that you do the fix yourself and open a pull request, not that you ask other people to do it for you.

picture Gymnasiast on 25 Jul 2018
👍4 😕1

All 3 comments

I think you're referring to the nullptr check if _lastDisconnectReason? That's correct, yes, it is not needed. Can you open a pull request for it?

Gymnasiast picture Gymnasiast on 25 Jul 2018

Would any other software developers like to improve affected places quicker (than me)?

elfring picture elfring on 25 Jul 2018

The idea of open source is that you do the fix yourself and open a pull request, not that you ask other people to do it for you.

Gymnasiast picture Gymnasiast on 25 Jul 2018
👍4 😕1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Nubbie picture Nubbie  ·  3Comments
telk5093 picture telk5093  ·  3Comments
deurklink picture deurklink  ·  3Comments
deurklink picture deurklink  ·  3Comments
Ionaru picture Ionaru  ·  3Comments