Openrct2: Request: Increase the maximum parameters for park goals

[LordMarcel]

Right now the maximum number of guests for a scenario goal is 5000, the maximum park value is €2.000.000, the maximum excitement rating for coasters is 9.90, and the maximum monthly income is €2.000.000.

Some of these are higher than you can ever reach, but the maximum for guests, park value, and excitement certainly aren't. It would be great if these limits are raised so that we can make more difficult scenario goals.

[Broxzier]

These limits are hardcoded in EditorObjectiveOptions.cpp: https://github.com/OpenRCT2/OpenRCT2/blob/develop/src/openrct2-ui/windows/EditorObjectiveOptions.cpp#L573-L619

These can probably be increased without weird side-effects. The number of guests is of course limited to the maximum number of sprites, but reaching 5000+ guests is not very difficult on very large parks.

[deurklink]

Actually the limits are in these lines: https://github.com/OpenRCT2/OpenRCT2/blob/develop/src/openrct2-ui/windows/EditorObjectiveOptions.cpp#L573-L687
The lines you highlighted are the standard arguments that get filled in when selecting an objective. :wink:
Now a good question is probably what the new limits should be?

Something that also struck me as weird is that the rollercoaster length objective uses the same variable for its objective as the number of guests:

case OBJECTIVE_10_ROLLERCOASTERS_LENGTH:
        gScenarioObjectiveNumGuests = 1200;
        break;

Maybe this variable should be renamed?

[Broxzier]

Likewise gScenarioObjectiveCurrency is also used for ride excitement. They use the same memory, but the variable name doesn't match all its uses.

[LordMarcel]

I suggest a max of 9600 for the guest count, as 9601 is the current maximum possible number of guests. The highest park value I've gotten is 33 million, but higher is probably possible, so to be safe something like 100 million would be a safe max. The highest excitement I've gotten is 312 and I know 400 is theoretically possible, so to be all-inclusive a limit at 400 would be necessary. However, I don't think anyone is going to run into issues if the limit is around 20. For ride length the maximum possible is 32767 meters, so 32800 would be a good limit. The monthly income maximum is currently high enough, as the highest I've ever gotten is only €500.000.

[deurklink]

We'll probably want to keep it future-proof. Parks with over 10000 guests will be no issue (besides lag) when we have the new save format.

[Umdlye]

As for the excitement rating limit, I believe scenario creators should be warned when they pick an objective that is (nearly) impossible to reach through "normal" play.

The best solution IMO would be to keep the limit at 9.90 through the up/down arrows but allow entering of a number between 1 and 400 when you click the field (possibly with a disclaimer in the entry window).

[James103]

What is the maximum that a scenario can charge for you (the player) to buy a tile of land? I've seen amounts as high as $150/tile in some scenarios and as low as $20/tile in others.

[Umdlye]

The current max is $200 per tile.

[James103]

I suggest a max of 65,000 for the guest count once the new save format is implemented. The max sprite limit is now 65,536 (65,136), but it will require at least 136 other sprites (staff, rides, other) to reach 65,000 guests in normal play without any cheats.

If possible, I also suggest a date limit of October 31, Year 255. This should fit in a 16-bit integer even if objective dates are changed to specify the number of days since March 1, Year 1.

[janisozaur]

For all possible extensions of victory conditions there should be a confirmed path of not using cheats to win them. Preferably using a replay and be included in our test suite.

[James103]

What I just suggested above should be considered an upper bound on the limit, The date limit can remain as is, but I would like for the guest limit to at least be somewhere around 50,000, which still leaves about 20% of the possible sprites usable for rides, staff, and other things that use sprites.

Note that I would still have to wait for someone to prove what the highest possible number of guests in the park is given that the park rating must be at least 600 before the limit is set fully.

[duncanspumpkin]

There is a soft limit for guests which would prevent you ever getting to that limit. And also vehicles are part of the same limit.

[James103]

Around 10k guests should be the bare minimum new limit, since it is possible to exceed that in RCT Classic (somebody even managed to reach 11k guests according to https://www.reddit.com/r/rct/comments/9z76w9/classic_claustrofobia_a_park_with_11111_guests/).

[LordMarcel]

Funnily enough that someone is me, the same person who originally made this issue. I'd be happy to test how many guests I can get with 600 rating once the new save file is up and running.

[ocalhoun6]

For all possible extensions of victory conditions there should be a confirmed path of not using cheats to win them. Preferably using a replay and be included in our test suite.

That should probably be split off into a different issue?

And maybe certain cheats shouldn't be barred from scenario victory? Aesthetic things like the ducks and maybe using zero clearance probably shouldn't invalidate your scenario win just because you were trying to make it look pretty.

[janisozaur]

This is simply to ensure that impossible conditions are not introduced or if regression happens making it impossible to win, it gets caught.