Openrct2: Ride time in stats window gets cut off when using many stations

[deurklink]

OS: [Windows 8.1]
Version: [0.1.2]
Commit/Build: [original bug]

When you build a ride with 4 stations, the ride time in the stats window will be cut off. Perhaps it would be better if we could resize the stats window, especially when at some point the maximum number of stations will be increased.

• [x] Reproducible in RCT2 (vanilla)?
• [x] Multiplayer?

Steps to reproduce:

1. Build ride with 4 stations
2. Go to stats window and check ride times

Screenshots / Video:

Save file
This save file has 2 monorails with 4 stations:
Space Base 15.zip

[Gymnasiast]

Or get rid of the idiosyncratic notation.
For Dutch, I replaced this with 1m 12s, which does make it fit.

[deurklink]

I think this should be made future-proof however. What if we can make rides with 8 stations?

[Ryder17z]

@Gymnasiast Same fix can be applied to Swedish and probably a majority of other languages as well.

@deurklink automatic line break like this?:

Example A:
Ride Time: 1min:42s / 3min:1s / 2min:32s /
1min:12s / 4min:1s / 1min:32s / 3min:3s /
(continue till limit/amount of stations is reached)

Example B:
Ride Time: 1min:42s / 3min:1s /
2min:32s / 1min:12s / 4min:1s /
1min:32s / 3min:3s /
(continue till limit/amount of stations is reached)

[Gymnasiast]

automatic line break like this

Our window system is not flexible enough for that, unfortunately.

[AaronVanGeffen]

Line wrapping the text in question would be a trivial change:

diff --git a/src/openrct2-ui/windows/Ride.cpp b/src/openrct2-ui/windows/Ride.cpp
index 90b296d29..b1f6c2b3b 100644
--- a/src/openrct2-ui/windows/Ride.cpp
+++ b/src/openrct2-ui/windows/Ride.cpp
@@ -5397,8 +5397,8 @@ static void window_ride_measurements_paint(rct_window *w, rct_drawpixelinfo *dpi
                 set_format_arg(2 + (numLengths * 4), uint16, 0);
                 set_format_arg(4 + (numLengths * 4), uint16, 0);
                 set_format_arg(6 + (numLengths * 4), uint16, 0);
-                gfx_draw_string_left_clipped(dpi, STR_RIDE_LENGTH, gCommonFormatArgs, COLOUR_BLACK, x, y, 308);
-                y += LIST_ROW_HEIGHT;
+                y += gfx_draw_string_left_wrapped(dpi, gCommonFormatArgs, x, y, 308, STR_RIDE_LENGTH, COLOUR_BLACK);

                 if (ride_type_has_flag(ride->type, RIDE_TYPE_FLAG_HAS_G_FORCES)) {
                     // Max. positive vertical G's

There is enough empty space for line-wrapped text for transportation rides at least, but I'm wondering how this would fare for other rides that allow having several stations.

In #7562, @deurklink proposed we make the ride window resizeable in the statistics tab as well, to help in these situations. I'm wondering whether it'd be feasible to resize the window outright instead, depending on how many lines there will be in the window. That could work with automatic line breaking as well.

The implementation for this would be a little hacky, mind you, but like @Gymnasiast said, we'd have to work around the limits of the current window system.

For the short term, a nicer option would be to abbreviate the units as-is, I think. As @Gymnasiast suggested:

For Dutch, I replaced this with 1m 12s, which does make it fit.

It would be trivial to do this for other languages as well.

[deurklink]

Maybe you could show what the different options would look like?
I think that will help us decide what looks the best.

[AaronVanGeffen]

On develop, unchanged:

Simple text wrapping applied:

With shorter units:

Resizeable: