Openrct2: Minimum Energy Cheat Bug

[roboexplorer]

OS: Windows 10
Version: 0.1.2-develop
Commit/Build: 6547116

Setting guests' energy to minimum using cheats causes their energy to be set at minimum as intended but receive a sudden energy boost after a second or two. The energy bar will also be off the screen when observing guest stats when it happens.

• [ Y ] Reproducible in RCT2 (vanilla)?
• [ Y ] Multiplayer?

Steps to reproduce:

1. Have any number of guests in the park
2. Set guests' energy to minimum using cheats

Screenshots / Video:

[janisozaur]

Must be a case of nuclear Gandhi.

[roboexplorer]

I wish to add further to this bug:
Energy drain (and/or gain?) isn't working correctly with this same build. Opened a random scenario (screenshot of Six Flags Great Belgium) and multiple guests had energy off the charts. I tried to tire some guests out to see if their energy decreases but I could not even tire a guest to minimum by restricting them on a single path tile at turbo speed. Their energy does not decrease from their intended maximum. The only time they actually lose energy is when they their energy is above maximum. Similar situation in multiplayer as well. This happens without cheats.

Six Flags Great Belgium:

[60trainhunter]

guests wont ever lose energy either without cheat.

[Gymnasiast]

Issue was caused by using max(MAX_ENERGY, proposed_energy_level), rather than the intended min. So the code that was intended to prevent overflows would not do so, and at the same time would make sure energy never dropped below the max of 128! This explains both @roboexplorer 's and @60trainhunter 's issues.

A PR with a fix has been opened.