Openrct2: Rain doesn't reach the bottom of the screen

[Pikamander2]

OS: Windows 10
Version: 2.01.028
Commit/Build: 0.0.7-develop-f26380c

The bottom of the screen doesn't show rain. It lines up perfectly with the money counter and calendar, so it seems like there's an invisible bar or something covering up the rain and causing it to not get drawn.

Steps to reproduce:

1. Start a new game
2. Open the cheats menu
3. Force the weather to be rain (or heavy rain, or thunderstorm)
4. The bottom of the screen will not have any rain

Screenshots / Video:

[Gymnasiast]

I was certain this was a duplicate, but I can't seem to find the bug, so I guess this wasn't reported because it was too obvious.

[janisozaur]

https://github.com/OpenRCT2/OpenRCT2/issues/2607

[Gymnasiast]

@janisozaur #2607 has nothing to do with this. This is not about rain in an additional viewport.

[janisozaur]

me:

Possibly related: Rain is not rendered in bottom and top areas (with toolbars)

Duncan:

This is a known bug. Rain is done a bit oddly and is placed after toolbars are drawn so you end up with this.

[Gymnasiast]

" Possibly "
These are two different issues that _might_ be related, but still are two different issues.

[duncanspumpkin]

This is a duplicate it's all because it draws rain too late.

[IntelOrca]

I don't think it should be marked as duplicate, as @Gymnasiast said - issues should be based on issues rather than causes. Otherwise it is more likely to get raised again. A fix can fix one or more issues.

[MeesterDev]

It might be superfluous to add this, but the rain is also missing from the top of the screen (also visible in the screenshots). [I'm using 0.0.8-develop 787ddf8]

[Nubbie]

related to #676 & #2249

[suipaste]

As far as I can see there is a gap at the top and the bottom because the rain is drawn on top of the tool bars. I changed the height of them to see what happened and the rain drew on top.

I'm new to openrct2 development but does anyone know where the code which governs the draw order occurs?

[JoelLarson]

I've debugged this issue and think there are a couple of solutions that could work. I validated the rain can be drawn provided there isn't a window with a transparent background.

The solutions seem to be:

• Changing the rain drawing to draw over the empty area of windows
• Create new "windows" for each group of widgets to remove the transparent background
• Rework rain drawing

I think the second solution is the most practical as the rain drawing is currently a recursive headache.

[duncanspumpkin]

What we want to do is make effects like this apply to the viewport post rendering but prior to ui drawing. We haven't split up the ui from the rest of the viewport drawing yet though.